Skip to content

Commit

Permalink
bpo-46630: Fix initial focus of IDLE query dialogs (GH-31112)
Browse files Browse the repository at this point in the history
On Windows, one had to Tab or click on the entry box
to get a cursor and be able to enter anything.
(cherry picked from commit d1df81a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
  • Loading branch information
miss-islington and terryjreedy committed Feb 3, 2022
1 parent 63523e7 commit 4f76b36
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions Lib/idlelib/NEWS.txt
Expand Up @@ -4,6 +4,9 @@ Released on 2022-05-16
=========================


bpo-46630: Make query dialogs on Windows start with a cursor in the
entry box.

bpo-46591: Make the IDLE doc URL on the About IDLE dialog clickable.

bpo-45296: Clarify close, quit, and exit in IDLE. In the File menu,
Expand Down
2 changes: 1 addition & 1 deletion Lib/idlelib/query.py
Expand Up @@ -83,6 +83,7 @@ def __init__(self, parent, title, message, *, text0='', used_names={},

if not _utest:
self.deiconify() # Unhide now that geometry set.
self.entry.focus_set()
self.wait_window()

def create_widgets(self, ok_text='OK'): # Do not replace.
Expand All @@ -100,7 +101,6 @@ def create_widgets(self, ok_text='OK'): # Do not replace.
text=self.message)
self.entryvar = StringVar(self, self.text0)
self.entry = Entry(frame, width=30, textvariable=self.entryvar)
self.entry.focus_set()
self.error_font = Font(name='TkCaptionFont',
exists=True, root=self.parent)
self.entry_error = Label(frame, text=' ', foreground='red',
Expand Down
@@ -0,0 +1 @@
Make query dialogs on Windows start with a cursor in the entry box.

0 comments on commit 4f76b36

Please sign in to comment.