Skip to content

Commit

Permalink
gh-109566: regrtest --fast-ci no longer enables --nowindows (#110121)
Browse files Browse the repository at this point in the history
The --nowindows option is deprecated and does nothing but logs a
warning.
  • Loading branch information
vstinner committed Sep 29, 2023
1 parent 9c91141 commit 5ae6c6d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 1 addition & 5 deletions Lib/test/libregrtest/cmdline.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import sys
from test.support import os_helper

from .utils import MS_WINDOWS


USAGE = """\
python -m test [options] [test_name1 [test_name2 ...]]
Expand Down Expand Up @@ -414,7 +412,7 @@ def _parse_args(args, **kwargs):
# Similar to options:
#
# -j0 --randomize --fail-env-changed --fail-rerun --rerun
# --slowest --verbose3 --nowindows
# --slowest --verbose3
if ns.use_mp is None:
ns.use_mp = 0
ns.randomize = True
Expand All @@ -424,8 +422,6 @@ def _parse_args(args, **kwargs):
ns.rerun = True
ns.print_slow = True
ns.verbose3 = True
if MS_WINDOWS:
ns.nowindows = True # Silence alerts under Windows
else:
ns._add_python_opts = False

Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_regrtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,6 @@ def test_unknown_option(self):

def check_ci_mode(self, args, use_resources, rerun=True):
ns = cmdline._parse_args(args)
if utils.MS_WINDOWS:
self.assertTrue(ns.nowindows)

# Check Regrtest attributes which are more reliable than Namespace
# which has an unclear API
Expand Down

0 comments on commit 5ae6c6d

Please sign in to comment.