Skip to content

Commit

Permalink
bpo-35518: Skip test that relies on a deceased network service. (GH-1…
Browse files Browse the repository at this point in the history
…5349)

If this service had thoroughly vanished, we could just ignore the
test until someone gets around to either recreating such a service
or redesigning the test to somehow work locally.  The
`support.transient_internet` mechanism catches the failure to
resolve the domain name, and skips the test.

But in fact the domain snakebite.net does still exist, as do its
nameservers -- and they can be quite slow to reply.  As a result
this test can easily take 20-30s before it gets auto-skipped.

So, skip the test explicitly up front.
  • Loading branch information
gnprice authored and benjaminp committed Aug 21, 2019
1 parent d33e46d commit 5b95a15
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Lib/test/test_timeout.py
Expand Up @@ -150,6 +150,7 @@ def setUp(self):
def tearDown(self):
self.sock.close()

@unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
def testConnectTimeout(self):
# Testing connect timeout is tricky: we need to have IP connectivity
# to a host that silently drops our packets. We can't simulate this
Expand Down

0 comments on commit 5b95a15

Please sign in to comment.