Skip to content

Commit

Permalink
Use a more robust infinity check in _Py_HashDouble.
Browse files Browse the repository at this point in the history
This fixes a test_decimal failure on FreeBSD 8.0.  (modf apparently
doesn't follow C99 Annex F on FreeBSD.)
  • Loading branch information
mdickinson committed Apr 5, 2010
1 parent 0c08009 commit 5e0c274
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
9 changes: 9 additions & 0 deletions Lib/test/test_float.py
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,15 @@ def notest_float_inf(self):
self.assertFalse(NAN.is_inf())
self.assertFalse((0.).is_inf())

def test_hash_inf(self):
# the actual values here should be regarded as an
# implementation detail, but they need to be
# identical to those used in the Decimal module.
self.assertEqual(hash(float('inf')), 314159)
self.assertEqual(hash(float('-inf')), -271828)
self.assertEqual(hash(float('nan')), 0)


fromHex = float.fromhex
toHex = float.hex
class HexFloatTestCase(unittest.TestCase):
Expand Down
6 changes: 3 additions & 3 deletions Objects/object.c
Original file line number Diff line number Diff line change
Expand Up @@ -1025,15 +1025,15 @@ _Py_HashDouble(double v)
* of mapping keys will turn out weird.
*/

if (Py_IS_INFINITY(v))
/* can't convert to long int -- arbitrary */
v = v < 0 ? -271828.0 : 314159.0;
fractpart = modf(v, &intpart);
if (fractpart == 0.0) {
/* This must return the same hash as an equal int or long. */
if (intpart > LONG_MAX/2 || -intpart > LONG_MAX/2) {
/* Convert to long and use its hash. */
PyObject *plong; /* converted to Python long */
if (Py_IS_INFINITY(intpart))
/* can't convert to long int -- arbitrary */
v = v < 0 ? -271828.0 : 314159.0;
plong = PyLong_FromDouble(v);
if (plong == NULL)
return -1;
Expand Down

0 comments on commit 5e0c274

Please sign in to comment.