gh-93761: Fix test to avoid simple delay when synchronizing.

python · Jun 13, 2022 · 6e5b7cb · 6e5b7cb
1 parent 3ceb4b8
commit 6e5b7cb
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
@@ -3609,13 +3609,15 @@ def do_queuehandler_configuration(self, qspec, lspec):
             self.assertEqual(sorted(logging.getHandlerNames()), ['ah', 'h1'])
             self.assertIsNotNone(qh.listener)
             qh.listener.start()
-            # Need to let the listener thread get started
-            time.sleep(delay)
             logging.debug('foo')
             logging.info('bar')
             logging.warning('baz')
             # Need to let the listener thread finish its work
-            time.sleep(delay)
+            deadline = time.monotonic() + support.LONG_TIMEOUT
+            while not qh.listener.queue.empty():
+                time.sleep(delay)
+                if time.monotonic() > deadline:
+                    self.fail("queue not empty")
             with open(fn, encoding='utf-8') as f:
                 data = f.read().splitlines()
             self.assertEqual(data, ['foo', 'bar', 'baz'])