Skip to content

Commit

Permalink
bpo-46591: Make About IDLE doc link label clickable (GH-30251)
Browse files Browse the repository at this point in the history
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 53c7808)

Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
  • Loading branch information
miss-islington and wesinator committed Feb 2, 2022
1 parent e5e1441 commit 7dee93c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 2 additions & 0 deletions Lib/idlelib/NEWS.txt
Expand Up @@ -4,6 +4,8 @@ Released on 2022-05-16
=========================


bpo-46591: Make the IDLE doc URL on the About IDLE dialog clickable.

bpo-45296: Clarify close, quit, and exit in IDLE. In the File menu,
'Close' and 'Exit' are now 'Close Window' (the current one) and 'Exit'
is now 'Exit IDLE' (by closing all windows). In Shell, 'quit()' and
Expand Down
2 changes: 2 additions & 0 deletions Lib/idlelib/help_about.py
Expand Up @@ -3,6 +3,7 @@
"""
import os
import sys
import webbrowser
from platform import python_version, architecture

from tkinter import Toplevel, Frame, Label, Button, PhotoImage
Expand Down Expand Up @@ -94,6 +95,7 @@ def create_widgets(self):
f"{version[:version.rindex('.')]}/library/idle.html",
justify=LEFT, fg=self.fg, bg=self.bg)
docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0)
docs.bind("<Button-1>", lambda event: webbrowser.open(docs['text']))

Frame(frame_background, borderwidth=1, relief=SUNKEN,
height=2, bg=self.bg).grid(row=8, column=0, sticky=EW,
Expand Down
4 changes: 2 additions & 2 deletions Lib/idlelib/idle_test/htest.py
Expand Up @@ -77,8 +77,8 @@ def _wrapper(parent): # htest #
'kwds': {'title': 'help_about test',
'_htest': True,
},
'msg': "Test every button. Ensure Python, TK and IDLE versions "
"are correctly displayed.\n [Close] to exit.",
'msg': "Click on URL to open in default browser.\n"
"Verify x.y.z versions and test each button, including Close.\n "
}

# TODO implement ^\; adding '<Control-Key-\\>' to function does not work.
Expand Down
@@ -0,0 +1 @@
Make the IDLE doc URL on the About IDLE dialog clickable.

0 comments on commit 7dee93c

Please sign in to comment.