bpo-9850: Deprecate the macpath module (#1540)

Co-Authored-By: Chi Hsuan Yen <yan12125@gmail.com>.
python · May 15, 2017 · 89a1c93 · 89a1c93
1 parent 981096f
commit 89a1c93
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/Doc/library/macpath.rst b/Doc/library/macpath.rst
@@ -6,6 +6,8 @@
 
 **Source code:** :source:`Lib/macpath.py`
 
+.. deprecated-removed:: 3.7 3.8
+
 --------------
 
 This module is the Mac OS 9 (and earlier) implementation of the :mod:`os.path`

diff --git a/Doc/whatsnew/3.7.rst b/Doc/whatsnew/3.7.rst
@@ -265,6 +265,8 @@ Deprecated
   now deprecated.  It never correctly worked. (Contributed by Serhiy Storchaka
   in :issue:`28692`.)
 
+- The :mod:`macpath` is now deprecated and will be removed in Python 3.8.
+
 
 Changes in the C API
 --------------------

diff --git a/Lib/macpath.py b/Lib/macpath.py
@@ -4,6 +4,10 @@
 from stat import *
 import genericpath
 from genericpath import *
+import warnings
+
+warnings.warn('the macpath module is deprecated in 3.7 and will be removed '
+              'in 3.8', DeprecationWarning, stacklevel=2)
 
 __all__ = ["normcase","isabs","join","splitdrive","split","splitext",
            "basename","dirname","commonprefix","getsize","getmtime",

diff --git a/Lib/test/test_macpath.py b/Lib/test/test_macpath.py
@@ -1,6 +1,12 @@
-import macpath
 from test import test_genericpath
 import unittest
+import warnings
+
+
+with warnings.catch_warnings():
+    warnings.filterwarnings("ignore", "the macpath module is deprecated",
+                            DeprecationWarning)
+    import macpath
 
 
 class MacPathTestCase(unittest.TestCase):