bpo-39453: Add testcase for bpo-39453 (GH-18202)

https://bugs.python.org/issue39453 Automerge-Triggered-By: @pablogsal Automerge-Triggered-By: @pablogsal
python · Jan 27, 2020 · 9e1ed51 · 9e1ed51
1 parent 7023288
commit 9e1ed51
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Lib/test/test_list.py b/Lib/test/test_list.py
@@ -225,6 +225,8 @@ def __eq__(self, other):
         # to list elements while calling PyObject_RichCompareBool().
         lst = [X(), X()]
         3 in lst
+        lst = [X(), X()]
+        X() in lst
 
 
 if __name__ == "__main__":

diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -452,7 +452,7 @@ list_contains(PyListObject *a, PyObject *el)
     for (i = 0, cmp = 0 ; cmp == 0 && i < Py_SIZE(a); ++i) {
         item = PyList_GET_ITEM(a, i);
         Py_INCREF(item);
-        cmp = PyObject_RichCompareBool(PyList_GET_ITEM(a, i), el, Py_EQ);
+        cmp = PyObject_RichCompareBool(item, el, Py_EQ);
         Py_DECREF(item);
     }
     return cmp;