Skip to content

Commit

Permalink
Use bool in fileinput.input() docstring and tests for the inplace arg…
Browse files Browse the repository at this point in the history
…ument (GH-111998)

The `.rst` docs, most tests, and typeshed already use bool for it.
  • Loading branch information
scop committed Jan 27, 2024
1 parent 823a38a commit a768e12
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Lib/fileinput.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
sequence must be accessed in strictly sequential order; sequence
access and readline() cannot be mixed.
Optional in-place filtering: if the keyword argument inplace=1 is
Optional in-place filtering: if the keyword argument inplace=True is
passed to input() or to the FileInput constructor, the file is moved
to a backup file and standard output is directed to the input file.
This makes it possible to write a filter that rewrites its input file
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_fileinput.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def test_buffer_sizes(self):
print('6. Inplace')
savestdout = sys.stdout
try:
fi = FileInput(files=(t1, t2, t3, t4), inplace=1, encoding="utf-8")
fi = FileInput(files=(t1, t2, t3, t4), inplace=True, encoding="utf-8")
for line in fi:
line = line[:-1].upper()
print(line)
Expand Down Expand Up @@ -256,7 +256,7 @@ def test_detached_stdin_binary_mode(self):
def test_file_opening_hook(self):
try:
# cannot use openhook and inplace mode
fi = FileInput(inplace=1, openhook=lambda f, m: None)
fi = FileInput(inplace=True, openhook=lambda f, m: None)
self.fail("FileInput should raise if both inplace "
"and openhook arguments are given")
except ValueError:
Expand Down

0 comments on commit a768e12

Please sign in to comment.