Skip to content

Commit

Permalink
Fix various ParamSpec errors in typing (GH-24176)
Browse files Browse the repository at this point in the history
1. ParamSpec -> TypeVar for ``typing.Concatenate``
2. ParamSpec's call signature should align with its documentation.
Noticed in GH-24169
  • Loading branch information
Fidget-Spinner committed Jan 11, 2021
1 parent 81f87bb commit ace008c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Doc/library/typing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,10 @@ These can be used as types in annotations using ``[]``, each having a unique syn

from collections.abc import Callable
from threading import Lock
from typing import Any, Concatenate, ParamSpec
from typing import Any, Concatenate, ParamSpec, TypeVar

P = ParamSpec('P')
R = ParamSpec('R')
R = TypeVar('R')

# Use this lock to ensure that only one thread is executing a function
# at any time.
Expand Down
2 changes: 1 addition & 1 deletion Lib/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ def add_two(x: float, y: float) -> float:
args = object()
kwargs = object()

def __init__(self, name, bound=None, covariant=False, contravariant=False):
def __init__(self, name, *, bound=None, covariant=False, contravariant=False):
self.__name__ = name
super().__init__(bound, covariant, contravariant)
try:
Expand Down

0 comments on commit ace008c

Please sign in to comment.