Skip to content

Commit

Permalink
[3.12] gh-105979: Fix exception handling in unmarshal_frozen_code (…
Browse files Browse the repository at this point in the history
…`Python/import.c`) (GH-105980) (#106055)

gh-105979: Fix exception handling in `unmarshal_frozen_code` (`Python/import.c`) (GH-105980)
(cherry picked from commit cd52803)

Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
  • Loading branch information
miss-islington and chgnrdv committed Jun 26, 2023
1 parent e9366df commit b786fe8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Lib/test/test_import/__init__.py
Expand Up @@ -23,6 +23,7 @@
import unittest
from unittest import mock
import _testinternalcapi
import _imp

from test.support import os_helper
from test.support import (
Expand Down Expand Up @@ -763,6 +764,13 @@ def test_dll_dependency_import(self):
env=env,
cwd=os.path.dirname(pyexe))

def test_issue105979(self):
# this used to crash
with self.assertRaises(ImportError) as cm:
_imp.get_frozen_object("x", b"6\'\xd5Cu\x12")
self.assertIn("Frozen object named 'x' is invalid",
str(cm.exception))


@skip_if_dont_write_bytecode
class FilePermissionTests(unittest.TestCase):
Expand Down
@@ -0,0 +1 @@
Fix crash in :func:`!_imp.get_frozen_object` due to improper exception handling.
1 change: 1 addition & 0 deletions Python/import.c
Expand Up @@ -2053,6 +2053,7 @@ unmarshal_frozen_code(PyInterpreterState *interp, struct frozen_info *info)
PyObject *co = PyMarshal_ReadObjectFromString(info->data, info->size);
if (co == NULL) {
/* Does not contain executable code. */
PyErr_Clear();
set_frozen_error(FROZEN_INVALID, info->nameobj);
return NULL;
}
Expand Down

0 comments on commit b786fe8

Please sign in to comment.