Skip to content

Commit

Permalink
Added kw_only parameter to make_dataclasses. (GH-29679)
Browse files Browse the repository at this point in the history
(cherry picked from commit f7638dd)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
  • Loading branch information
miss-islington and ericvsmith committed Nov 20, 2021
1 parent 3528df1 commit cf8c878
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Lib/dataclasses.py
Expand Up @@ -1326,7 +1326,7 @@ def _astuple_inner(obj, tuple_factory):

def make_dataclass(cls_name, fields, *, bases=(), namespace=None, init=True,
repr=True, eq=True, order=False, unsafe_hash=False,
frozen=False, match_args=True, slots=False):
frozen=False, match_args=True, kw_only=False, slots=False):
"""Return a new dynamically created dataclass.
The dataclass name will be 'cls_name'. 'fields' is an iterable
Expand Down Expand Up @@ -1393,7 +1393,7 @@ def exec_body_callback(ns):
# Apply the normal decorator.
return dataclass(cls, init=init, repr=repr, eq=eq, order=order,
unsafe_hash=unsafe_hash, frozen=frozen,
match_args=match_args, slots=slots)
match_args=match_args, kw_only=kw_only, slots=slots)


def replace(obj, /, **changes):
Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_dataclasses.py
Expand Up @@ -3864,5 +3864,16 @@ class A:
c: int = 1
d: int

def test_make_dataclass(self):
A = make_dataclass("A", ['a'], kw_only=True)
self.assertTrue(fields(A)[0].kw_only)

B = make_dataclass("B",
['a', ('b', int, field(kw_only=False))],
kw_only=True)
self.assertTrue(fields(B)[0].kw_only)
self.assertFalse(fields(B)[1].kw_only)


if __name__ == '__main__':
unittest.main()
@@ -0,0 +1 @@
Added missing kw_only parameter to dataclasses.make_dataclass().

0 comments on commit cf8c878

Please sign in to comment.