Skip to content

Commit

Permalink
bpo-42847: Normalise Lib/sqlite3/test/* file encodings (GH-24147)
Browse files Browse the repository at this point in the history
Convert from ISO-8859-1 to UTF-8.
  • Loading branch information
Erlend Egeberg Aasland committed Jan 7, 2021
1 parent 849e339 commit deab1e5
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 21 deletions.
3 changes: 1 addition & 2 deletions Lib/sqlite3/test/dbapi.py
@@ -1,7 +1,6 @@
#-*- coding: iso-8859-1 -*-
# pysqlite2/test/dbapi.py: tests for DB-API compliance
#
# Copyright (C) 2004-2010 Gerhard Häring <gh@ghaering.de>
# Copyright (C) 2004-2010 Gerhard Häring <gh@ghaering.de>
#
# This file is part of pysqlite.
#
Expand Down
11 changes: 5 additions & 6 deletions Lib/sqlite3/test/factory.py
@@ -1,7 +1,6 @@
#-*- coding: iso-8859-1 -*-
# pysqlite2/test/factory.py: tests for the various factories in pysqlite
#
# Copyright (C) 2005-2007 Gerhard Häring <gh@ghaering.de>
# Copyright (C) 2005-2007 Gerhard Häring <gh@ghaering.de>
#
# This file is part of pysqlite.
#
Expand Down Expand Up @@ -235,20 +234,20 @@ def setUp(self):
self.con = sqlite.connect(":memory:")

def test_unicode(self):
austria = "Österreich"
austria = "Österreich"
row = self.con.execute("select ?", (austria,)).fetchone()
self.assertEqual(type(row[0]), str, "type of row[0] must be unicode")

def test_string(self):
self.con.text_factory = bytes
austria = "Österreich"
austria = "Österreich"
row = self.con.execute("select ?", (austria,)).fetchone()
self.assertEqual(type(row[0]), bytes, "type of row[0] must be bytes")
self.assertEqual(row[0], austria.encode("utf-8"), "column must equal original data in UTF-8")

def test_custom(self):
self.con.text_factory = lambda x: str(x, "utf-8", "ignore")
austria = "Österreich"
austria = "Österreich"
row = self.con.execute("select ?", (austria,)).fetchone()
self.assertEqual(type(row[0]), str, "type of row[0] must be unicode")
self.assertTrue(row[0].endswith("reich"), "column must contain original data")
Expand All @@ -258,7 +257,7 @@ def test_optimized_unicode(self):
with self.assertWarns(DeprecationWarning) as cm:
self.con.text_factory = sqlite.OptimizedUnicode
self.assertIn("factory.py", cm.filename)
austria = "Österreich"
austria = "Österreich"
germany = "Deutchland"
a_row = self.con.execute("select ?", (austria,)).fetchone()
d_row = self.con.execute("select ?", (germany,)).fetchone()
Expand Down
5 changes: 2 additions & 3 deletions Lib/sqlite3/test/hooks.py
@@ -1,7 +1,6 @@
#-*- coding: iso-8859-1 -*-
# pysqlite2/test/hooks.py: tests for various SQLite-specific hooks
#
# Copyright (C) 2006-2007 Gerhard Häring <gh@ghaering.de>
# Copyright (C) 2006-2007 Gerhard Häring <gh@ghaering.de>
#
# This file is part of pysqlite.
#
Expand Down Expand Up @@ -42,7 +41,7 @@ def test_create_collation_not_callable(self):
def test_create_collation_not_ascii(self):
con = sqlite.connect(":memory:")
with self.assertRaises(sqlite.ProgrammingError):
con.create_collation("collä", lambda x, y: (x > y) - (x < y))
con.create_collation("collä", lambda x, y: (x > y) - (x < y))

def test_create_collation_bad_upper(self):
class BadUpperStr(str):
Expand Down
3 changes: 1 addition & 2 deletions Lib/sqlite3/test/regression.py
@@ -1,7 +1,6 @@
#-*- coding: iso-8859-1 -*-
# pysqlite2/test/regression.py: pysqlite regression tests
#
# Copyright (C) 2006-2010 Gerhard Häring <gh@ghaering.de>
# Copyright (C) 2006-2010 Gerhard Häring <gh@ghaering.de>
#
# This file is part of pysqlite.
#
Expand Down
3 changes: 1 addition & 2 deletions Lib/sqlite3/test/transactions.py
@@ -1,7 +1,6 @@
#-*- coding: iso-8859-1 -*-
# pysqlite2/test/transactions.py: tests transactions
#
# Copyright (C) 2005-2007 Gerhard Häring <gh@ghaering.de>
# Copyright (C) 2005-2007 Gerhard Häring <gh@ghaering.de>
#
# This file is part of pysqlite.
#
Expand Down
11 changes: 5 additions & 6 deletions Lib/sqlite3/test/types.py
@@ -1,7 +1,6 @@
#-*- coding: iso-8859-1 -*-
# pysqlite2/test/types.py: tests for type conversion and detection
#
# Copyright (C) 2005 Gerhard Häring <gh@ghaering.de>
# Copyright (C) 2005 Gerhard Häring <gh@ghaering.de>
#
# This file is part of pysqlite.
#
Expand Down Expand Up @@ -41,10 +40,10 @@ def tearDown(self):
self.con.close()

def test_string(self):
self.cur.execute("insert into test(s) values (?)", ("Österreich",))
self.cur.execute("insert into test(s) values (?)", ("Österreich",))
self.cur.execute("select s from test")
row = self.cur.fetchone()
self.assertEqual(row[0], "Österreich")
self.assertEqual(row[0], "Österreich")

def test_small_int(self):
self.cur.execute("insert into test(i) values (?)", (42,))
Expand Down Expand Up @@ -75,9 +74,9 @@ def test_blob(self):
self.assertEqual(row[0], sample)

def test_unicode_execute(self):
self.cur.execute("select 'Österreich'")
self.cur.execute("select 'Österreich'")
row = self.cur.fetchone()
self.assertEqual(row[0], "Österreich")
self.assertEqual(row[0], "Österreich")

class DeclTypesTests(unittest.TestCase):
class Foo:
Expand Down

0 comments on commit deab1e5

Please sign in to comment.