Skip to content

Commit

Permalink
bpo-42972: _thread.RLock implements the GH protocol (GH-26734)
Browse files Browse the repository at this point in the history
The _thread.RLock type now fully implement the GC protocol: add a
traverse function and the Py_TPFLAGS_HAVE_GC flag.
(cherry picked from commit 1cd3d85)

Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
miss-islington and vstinner committed Jun 15, 2021
1 parent 2f2ea96 commit e30fe27
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The _thread.RLock type now fully implement the GC protocol: add a traverse
function and the :const:`Py_TPFLAGS_HAVE_GC` flag. Patch by Victor Stinner.
11 changes: 10 additions & 1 deletion Modules/_threadmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,14 @@ typedef struct {
PyObject *in_weakreflist;
} rlockobject;

static int
rlock_traverse(rlockobject *self, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(self));
return 0;
}


static void
rlock_dealloc(rlockobject *self)
{
Expand Down Expand Up @@ -579,13 +587,14 @@ static PyType_Slot rlock_type_slots[] = {
{Py_tp_alloc, PyType_GenericAlloc},
{Py_tp_new, rlock_new},
{Py_tp_members, rlock_type_members},
{Py_tp_traverse, rlock_traverse},
{0, 0},
};

static PyType_Spec rlock_type_spec = {
.name = "_thread.RLock",
.basicsize = sizeof(rlockobject),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC | Py_TPFLAGS_BASETYPE,
.slots = rlock_type_slots,
};

Expand Down

0 comments on commit e30fe27

Please sign in to comment.