Skip to content

Commit

Permalink
gh-97590: Update docs and tests for ftplib.FTP.voidcmd() (GH-96825)
Browse files Browse the repository at this point in the history
Since 2f3941d this function returns the
response string, rather than nothing.
  • Loading branch information
matthewhughes934 committed Feb 17, 2024
1 parent 26800cf commit e88ebc1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Doc/library/ftplib.rst
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ FTP objects
.. method:: FTP.voidcmd(cmd)

Send a simple command string to the server and handle the response. Return
nothing if a response code corresponding to success (codes in the range
200--299) is received. Raise :exc:`error_reply` otherwise.
the response string if the response code corresponds to success (codes in
the range 200--299). Raise :exc:`error_reply` otherwise.

.. audit-event:: ftplib.sendcmd self,cmd ftplib.FTP.voidcmd

Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_ftplib.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,8 @@ def test_set_pasv(self):
self.assertFalse(self.client.passiveserver)

def test_voidcmd(self):
self.client.voidcmd('echo 200')
self.client.voidcmd('echo 299')
self.assertEqual(self.client.voidcmd('echo 200'), '200')
self.assertEqual(self.client.voidcmd('echo 299'), '299')
self.assertRaises(ftplib.error_reply, self.client.voidcmd, 'echo 199')
self.assertRaises(ftplib.error_reply, self.client.voidcmd, 'echo 300')

Expand Down

0 comments on commit e88ebc1

Please sign in to comment.