Skip to content

Commit

Permalink
Fix the baffler that Tim reported: sometimes the repr() of an object
Browse files Browse the repository at this point in the history
looks like <X object at ...>, sometimes it says <X instance at ...>.
Make this uniformly say <X object at ...>.
  • Loading branch information
gvanrossum committed Sep 24, 2001
1 parent f244b2e commit ff0e6d6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Lib/test/test_descr.py
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,7 @@ def __getitem__(self, i):
verify(not c1 == c2)
# Note that the module name appears in str/repr, and that varies
# depending on whether this test is run standalone or from a framework.
verify(str(c1).find('C instance at ') >= 0)
verify(str(c1).find('C object at ') >= 0)
verify(str(c1) == repr(c1))
verify(-1 not in c1)
for i in range(10):
Expand All @@ -1216,7 +1216,7 @@ def __getitem__(self, i):
verify(not d1 == d2)
# Note that the module name appears in str/repr, and that varies
# depending on whether this test is run standalone or from a framework.
verify(str(d1).find('D instance at ') >= 0)
verify(str(d1).find('D object at ') >= 0)
verify(str(d1) == repr(d1))
verify(-1 not in d1)
for i in range(10):
Expand Down
4 changes: 2 additions & 2 deletions Objects/typeobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -1157,12 +1157,12 @@ object_repr(PyObject *self)
if (name == NULL)
return NULL;
if (mod != NULL && strcmp(PyString_AS_STRING(mod), "__builtin__"))
rtn = PyString_FromFormat("<%s.%s instance at %p>",
rtn = PyString_FromFormat("<%s.%s object at %p>",
PyString_AS_STRING(mod),
PyString_AS_STRING(name),
self);
else
rtn = PyString_FromFormat("<%s instance at %p>",
rtn = PyString_FromFormat("<%s object at %p>",
type->tp_name, self);
Py_XDECREF(mod);
Py_DECREF(name);
Expand Down

0 comments on commit ff0e6d6

Please sign in to comment.