Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code tables in _ssl and err_name_to_codes are no longer used #100062

Closed
davidben opened this issue Dec 6, 2022 · 1 comment
Closed

Error code tables in _ssl and err_name_to_codes are no longer used #100062

davidben opened this issue Dec 6, 2022 · 1 comment
Labels
extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error

Comments

@davidben
Copy link
Contributor

davidben commented Dec 6, 2022

(Filing this for a PR I'll upload shortly.)

Prior to #25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, these are no longer used and we can trim that a bit. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)

Linked PRs

@davidben davidben added the type-bug An unexpected behavior, bug, or error label Dec 6, 2022
davidben added a commit to davidben/cpython that referenced this issue Dec 6, 2022
…codes

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
davidben added a commit to davidben/cpython that referenced this issue Dec 6, 2022
…codes

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
@arhadthedev arhadthedev added extension-modules C modules in the Modules dir topic-SSL labels Apr 1, 2023
zooba pushed a commit that referenced this issue Apr 3, 2023
…H-100063)

Prior to #25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
@zooba
Copy link
Member

zooba commented Apr 3, 2023

Thanks!

@zooba zooba closed this as completed Apr 3, 2023
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this issue Apr 8, 2023
…codes (pythonGH-100063)

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
…codes (pythonGH-100063)

Prior to python#25300, the
make_ssl_data.py script used various tables, exposed in _ssl, to update
the error list.

After that PR, this is no longer used. Moreover, the err_names_to_codes
map isn't used at all. Clean those up. This gets them out of the way if,
in the future, OpenSSL provides an API to do what the code here is doing
directly. (openssl/openssl#19848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-modules C modules in the Modules dir topic-SSL type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants