Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate #include directives in multiple C files #102650

Closed
chgnrdv opened this issue Mar 13, 2023 · 0 comments · Fixed by #102651
Closed

Duplicate #include directives in multiple C files #102650

chgnrdv opened this issue Mar 13, 2023 · 0 comments · Fixed by #102651
Labels
type-bug An unexpected behavior, bug, or error

Comments

@chgnrdv
Copy link
Contributor

chgnrdv commented Mar 13, 2023 •
edited by bedevere-bot

These are examples of duplicate #include directives that, as far as I can see, do not cause any side effects and therefore can be freely removed (although I have doubts about few cases):

cpython/Mac/Tools/pythonw.c

Line 30 in 634cb61

#include <Python.h>

cpython/Modules/_hashopenssl.c

Line 40 in 634cb61

#include <openssl/crypto.h> // FIPS_mode()

cpython/Modules/arraymodule.c

Line 16 in 634cb61

#include <stddef.h>

cpython/Modules/signalmodule.c

Line 31 in 634cb61

#include "pycore_signal.h" // Py_NSIG

cpython/Programs/_testembed.c

Line 12 in 634cb61

#include <Python.h>

The PR is on the way.

Linked PRs
@chgnrdv chgnrdv added the type-bug An unexpected behavior, bug, or error label Mar 13, 2023
@chgnrdv chgnrdv mentioned this issue Mar 13, 2023
Merged
carljm pushed a commit that referenced this issue Mar 13, 2023
@chgnrdv
gh-102650: Remove duplicate include directives from multiple source f…
85ba8a3 
…iles (#102651)

Remove duplicate include directives from multiple source files
carljm added a commit to carljm/cpython that referenced this issue Mar 14, 2023
@carljm
Merge branch 'main' into inlinecomp2
6c5f269 
* main: (50 commits)
  pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685)
  pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661)
  pythongh-102354: change python3 to python in docs examples (python#102696)
  pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506)
  pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684)
  pythongh-100315: clarification to `__slots__` docs. (python#102621)
  pythonGH-100227: cleanup initialization of global interned dict (python#102682)
  doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677)
  pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014)
  pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649)
  pythongh-102627: Replace address pointing toward malicious web page (python#102630)
  pythongh-98831: Use DECREF_INPUTS() more (python#102409)
  pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659)
  pythongh-101524: Fix the ChannelID tp_name (pythongh-102655)
  pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075)
  pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
  pythongh-102650: Remove duplicate include directives from multiple source files (python#102651)
  pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640)
  pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631)
  ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@chgnrdv @Fidget-Spinner
pythongh-102650: Remove duplicate include directives from multiple so…
5814088 
…urce files (python#102651)

Remove duplicate include directives from multiple source files
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@chgnrdv @warsaw
pythongh-102650: Remove duplicate include directives from multiple so…
3519886 
…urce files (python#102651)

Remove duplicate include directives from multiple source files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-102650: Remove duplicate include directives from multiple source files chgnrdv/cpython
1 participant
@chgnrdv