Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused TKINTER_PROTECT_LOADTK code #103532

Closed
chrstphrchvz opened this issue Apr 14, 2023 · 1 comment
Closed

Remove unused TKINTER_PROTECT_LOADTK code #103532

chrstphrchvz opened this issue Apr 14, 2023 · 1 comment
Labels
stdlib Python modules in the Lib dir topic-tkinter type-feature A feature request or enhancement

Comments

@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented Apr 14, 2023 •
edited by bedevere-bot

The TKINTER_PROTECT_LOADTK macro and relevant code (originally for #49372) are only defined for Tk 8.4.13 and earlier, but Tkinter already requires at least 8.5.12. Is there a reason to keep this code around, or can it be removed?

Linked PRs
chrstphrchvz added a commit to chrstphrchvz/cpython that referenced this issue Apr 14, 2023
@chrstphrchvz
pythongh-103532: Remove TKINTER_PROTECT_LOADTK code
5becf1a 
This was only needed for Tk 8.4.13 and older,
but Tkinter already requires at least 8.5.12.
@bedevere-bot bedevere-bot mentioned this issue Apr 14, 2023
Merged
@arhadthedev arhadthedev added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Apr 14, 2023
zware pushed a commit that referenced this issue Apr 14, 2023
@chrstphrchvz
gh-103532: Remove TKINTER_PROTECT_LOADTK code (GH-103535)
69e2c42 
This was only needed for Tk 8.4.13 and older,
but Tkinter already requires at least 8.5.12.
@zware
Copy link
Member

zware commented Apr 14, 2023

Thanks for the report and patch!

@zware zware closed this as completed Apr 14, 2023
carljm added a commit to carljm/cpython that referenced this issue Apr 14, 2023
@carljm
Merge branch 'main' into superopt
64da49f 
* main:
  pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)
  pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)
  Remove double space in import error message (python#103458)
  ipaddress: Remove non-existent ip_str param from docstring (python#103461)
  Fix syntax typo in isolating extensions doc (python#103516)
  pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)
  Proofread howto/perf_profiling.rst (python#103530)
  Fix unused functions warnings in instrumentation.c (pythonGH-103515)
@hugovk hugovk mentioned this issue Apr 14, 2023
Closed
@bedevere-bot bedevere-bot mentioned this issue Apr 14, 2023
Merged
zware added a commit that referenced this issue Apr 14, 2023
@zware
gh-103532: Add NEWS entry (#103542)
e32c197
zware added a commit to zware/cpython that referenced this issue Apr 14, 2023
@zware
pythongh-103532: Add NEWS entry
04c39e4
@bedevere-bot bedevere-bot mentioned this issue Apr 14, 2023
Merged
zware added a commit to zware/cpython that referenced this issue Apr 14, 2023
@zware
pythongh-103532: Fix reST syntax in NEWS entry
ca1baf6
zware added a commit that referenced this issue Apr 14, 2023
@zware
gh-103532: Fix reST syntax in NEWS entry (GH-103544)
95ee7c4
carljm added a commit to carljm/cpython that referenced this issue Apr 14, 2023
@carljm
Merge branch 'superopt' into superopt_spec
b73cff0 
* superopt:
  fix incompatible types
  update generated cases
  don't unnecessarily re-find args in error case
  Apply suggestions from code review
  pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)
  pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)
  Remove double space in import error message (python#103458)
  ipaddress: Remove non-existent ip_str param from docstring (python#103461)
  Fix syntax typo in isolating extensions doc (python#103516)
  pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)
  Proofread howto/perf_profiling.rst (python#103530)
  Fix unused functions warnings in instrumentation.c (pythonGH-103515)
carljm added a commit to carljm/cpython that referenced this issue Apr 17, 2023
@carljm
Merge branch 'main' into superopt
5136459 
* main:
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
carljm added a commit to carljm/cpython that referenced this issue Apr 17, 2023
@carljm
Merge branch 'superopt' into superopt_spec
079c65a 
* superopt:
  update generated cases with new comment
  review comments
  Remove `expert-*` from `project-updater` GH workflow (python#103579)
  pythongh-103583: Add codecs and maps to _codecs_* module state (python#103540)
  pythongh-48330: address review comments to PR-12271 (python#103209)
  pythongh-103527: Add multibytecodec.h as make dep for _codecs_* (python#103567)
  pythongh-103553: Improve `test_inspect`: add more assertions, remove unused (python#103554)
  pythonGH-103517: Improve tests for `pathlib.Path.walk()` (pythonGH-103518)
  pythongh-102114: Make dis print more concise tracebacks for syntax errors in str inputs (python#102115)
  pythonGH-78079: Fix UNC device path root normalization in pathlib (pythonGH-102003)
  pythongh-101517: Add regression test for a lineno bug in try/except* impacting pdb (python#103547)
  pythongh-103527: Add make deps for _codecs_* and _multibytecodec (python#103528)
  pythongh-103532: Fix reST syntax in NEWS entry (pythonGH-103544)
  pythongh-103532: Add NEWS entry (python#103542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir topic-tkinter type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ronaldoussoren @arhadthedev @zware @chrstphrchvz