Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeAliasType should have a __module__ #104549

Closed
JelleZijlstra opened this issue May 16, 2023 · 0 comments
Closed

TypeAliasType should have a __module__ #104549

JelleZijlstra opened this issue May 16, 2023 · 0 comments
Assignees
@JelleZijlstra
Labels
topic-typing type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 16, 2023 •
edited by bedevere-bot

Currently the __module__ attribute of TypeAliasType instances (created through type X = ...) is always "typing". Let's set it to the actual module.

Linked PRs
@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error topic-typing labels May 16, 2023
@JelleZijlstra JelleZijlstra self-assigned this May 16, 2023
@bedevere-bot bedevere-bot mentioned this issue May 16, 2023
Merged
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 16, 2023
@JelleZijlstra
pythongh-104549: Set __module__ on TypeAliasType
98cc5fa
JelleZijlstra added a commit that referenced this issue May 18, 2023
@JelleZijlstra
gh-104549: Set __module__ on TypeAliasType (#104550)
b9dce3a
carljm added a commit to carljm/cpython that referenced this issue May 18, 2023
@carljm
Merge branch 'main' into nestedcomps
54095f0 
* main:
  pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)
  pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)
  pythongh-104050: Add more type annotations to Argument Clinic (python#104628)
  pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)
  pythongh-104549: Set __module__ on TypeAliasType (python#104550)
  pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)
  pythongh-104146: Remove unused vars from Argument Clinic (python#104627)
  pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)
  pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)
  pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)
  pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JelleZijlstra JelleZijlstra

Labels
topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JelleZijlstra