Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11: "Check if generated files are up to date" is failing due to autoconf version #105455

Closed
JelleZijlstra opened this issue Jun 7, 2023 · 5 comments
Labels
3.11 only security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Jun 7, 2023

On all 3.11 PRs that touch non-docs files (e.g. #105417), the Check if generated files are up to date check is currently failing on the check grep "Generated by GNU Autoconf 2.69" configure.

This is because d2340ef, which created 3.11.4, updated configure to be generated by Autoconf 2.71. @pablogsal why was this done? Should we update the build.yml file to check for 2.71 instead of 2.69?

Linked PRs

@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error build The build process and cross-build 3.11 only security fixes labels Jun 7, 2023
@ned-deily
Copy link
Member

ned-deily commented Jun 7, 2023

This is probably a side effect of the most recent PRs for #89886 which probably updated the container used to do autoconf operations. @erlend-aasland

@pablogsal
Copy link
Member

@pablogsal why was this done?

The release script runs it by running the autoconf step here:

https://github.com/python/release-tools/blob/8485d3b4d77a2559cbb3cf2e63dee43070327d50/run_release.py#L414-L429

@erlend-aasland
Copy link
Contributor

This is probably a side effect of the most recent PRs for #89886 which probably updated the container used to do autoconf operations. @erlend-aasland

We did not update the container. We just updated the CI and make to use the 271 tagged container. The release tools should use the correct tag depending on which release it is building.

@erlend-aasland
Copy link
Contributor

Either we reset configure using GNU Autoconf 2.69, or we backport the Autoconf 2.71 bump to 3.11. I guess the former is preferred, but the latter creates less churn. I can create PRs for both.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 7, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 7, 2023
Similar to pythongh-104925, but without a hard v2.71 requirement.
The hard check remains at Autoconf 2.69.

Co-authored-by: Christian Heimes <christian@python.org>
@erlend-aasland
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants