Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default return value of HTTPConnection.get_proxy_response_headers from {} to None #105626

Closed
sobolevn opened this issue Jun 10, 2023 · 2 comments
Closed

Change the default return value of HTTPConnection.get_proxy_response_headers from {} to None #105626

sobolevn opened this issue Jun 10, 2023 · 2 comments
Assignees
@sobolevn
Labels
3.12 bugs and security fixes 3.13 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jun 10, 2023 •
edited by bedevere-bot

See my reasoning here: #104248 (comment)

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir labels Jun 10, 2023
@sobolevn sobolevn self-assigned this Jun 10, 2023
@sobolevn sobolevn added 3.12 bugs and security fixes 3.13 new features, bugs and security fixes labels Jun 10, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Jun 10, 2023
@sobolevn
pythongh-105626: Change the default return value of `HTTPConnection.g…
50ae969 
…et_proxy_response_headers`
@bedevere-bot bedevere-bot mentioned this issue Jun 10, 2023
Merged
@sunmy2019
Copy link
Member

Indeed, None better represents what we have here.

gpshead pushed a commit that referenced this issue Jul 14, 2023
@sobolevn
gh-105626: Change the default return value of `HTTPConnection.get_pro…
490295d 
…xy_response_headers` (#105628)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2023
@sobolevn @miss-islington
pythongh-105626: Change the default return value of `HTTPConnection.g…
85ea8b9 
…et_proxy_response_headers` (pythonGH-105628)

(cherry picked from commit 490295d)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2023
Merged
gpshead pushed a commit that referenced this issue Jul 14, 2023
@miss-islington @sobolevn
[3.12] gh-105626: Change the default return value of `HTTPConnection.…
e68b280 
…get_proxy_response_headers` (GH-105628) (#106738)

gh-105626: Change the default return value of `HTTPConnection.get_proxy_response_headers` (GH-105628)
(cherry picked from commit 490295d)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
kgdiem pushed a commit to kgdiem/cpython that referenced this issue Jul 14, 2023
@sobolevn @kgdiem
pythongh-105626: Change the default return value of `HTTPConnection.g…
656c5bc 
…et_proxy_response_headers` (python#105628)
@hauntsaninja
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.12 bugs and security fixes 3.13 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @hauntsaninja @sunmy2019