Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys.getfilesystemencoding() should return interned string #106182

Closed
methane opened this issue Jun 28, 2023 · 0 comments · Fixed by #106183
Closed

sys.getfilesystemencoding() should return interned string #106182

methane opened this issue Jun 28, 2023 · 0 comments · Fixed by #106183
Labels
type-feature A feature request or enhancement

Comments

@methane
Copy link
Member

methane commented Jun 28, 2023 •
edited by bedevere-bot

Feature or enhancement

Intern sys.getfilesystemencoding() output.

Pitch

fsencoding string may be cached and reused.

(After sys._enablelegacywindowslegacyfsencoding() is removed, we can cache fsencoding object.)

Linked PRs
@methane methane added the type-feature A feature request or enhancement label Jun 28, 2023
@bedevere-bot bedevere-bot mentioned this issue Jun 28, 2023
Merged
@methane methane linked a pull request Jun 28, 2023 that will close this issue
gh-106182: sys: Intern getfilesystemencoding() and getfilesystemencodeerrors() #106183
Merged
methane added a commit that referenced this issue Jun 30, 2023
@methane
gh-106182: sys: Intern getfilesystemencoding() and getfilesystemencod…
f1034ba 
…eerrors() (#106183)

sys: Intern getfilesystemencoding() and getfilesystemencodeerrors()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-106182: sys: Intern getfilesystemencoding() and getfilesystemencodeerrors() methane/cpython
1 participant
@methane