Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten import trampoline is not needed #106210

Closed
hoodmane opened this issue Jun 28, 2023 · 0 comments
Closed

Emscripten import trampoline is not needed #106210

hoodmane opened this issue Jun 28, 2023 · 0 comments
Labels
OS-wasi type-feature A feature request or enhancement

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Jun 28, 2023 •
edited by bedevere-bot

As far as I know the import isn't actually needed. It was originally added to work around typos in the CPython test suite, but those typos have since been fixed and I am unaware of any user code that requires the trampoline.

Linked PRs
@hoodmane hoodmane added the type-feature A feature request or enhancement label Jun 28, 2023
@hoodmane hoodmane mentioned this issue Jun 28, 2023
Merged
brettcannon added a commit that referenced this issue Jun 30, 2023
@hoodmane @brettcannon
gh-106210 Remove Emscripten import trampoline (#106211)
e7bc8d1 
It's no longer necessary.

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-wasi type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @hoodmane @AlexWaygood