Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Include/cpython/pytime.h header file #106316

Closed
vstinner opened this issue Jul 1, 2023 · 0 comments
Closed

Remove Include/cpython/pytime.h header file #106316

vstinner opened this issue Jul 1, 2023 · 0 comments

Comments

@vstinner
Copy link
Member

vstinner commented Jul 1, 2023 •
edited by bedevere-bot

Remove Include/cpython/pytime.h header file: it only contains private functions and so far no one asked to expose public functions for this API.

I propose to move these functions to the internal pycore_time.h header file.

Linked PRs
vstinner added a commit to vstinner/cpython that referenced this issue Jul 1, 2023
@vstinner
pythongh-106316: Remove pytime.h header file
69b18fe 
Remove the "cpython/pytime.h" header file: it only contained private
functions. Move functions to the internal pycore_time.h header file.

Move tests from _testcapi to _testinternalcapi. Rename also test
methods to have the same name than tested C functions.
vstinner added a commit to vstinner/cpython that referenced this issue Jul 1, 2023
@vstinner
pythongh-106316: Remove pytime.h header file
4e20b33 
Remove the "cpython/pytime.h" header file: it only contained private
functions. Move functions to the internal pycore_time.h header file.

Move tests from _testcapi to _testinternalcapi. Rename also test
methods to have the same name than tested C functions.

No longer export these functions:

* _PyTime_Add()
* _PyTime_As100Nanoseconds()
* _PyTime_FromMicrosecondsClamp()
* _PyTime_FromTimespec()
* _PyTime_FromTimeval()
* _PyTime_GetPerfCounterWithInfo()
* _PyTime_MulDiv()
@bedevere-bot bedevere-bot mentioned this issue Jul 1, 2023
Merged
@vstinner vstinner mentioned this issue Jul 1, 2023
Closed
vstinner added a commit that referenced this issue Jul 1, 2023
@vstinner
gh-106316: Remove pytime.h header file (#106317)
46d7761 
Remove the "cpython/pytime.h" header file: it only contained private
functions. Move functions to the internal pycore_time.h header file.

Move tests from _testcapi to _testinternalcapi. Rename also test
methods to have the same name than tested C functions.

No longer export these functions:

* _PyTime_Add()
* _PyTime_As100Nanoseconds()
* _PyTime_FromMicrosecondsClamp()
* _PyTime_FromTimespec()
* _PyTime_FromTimeval()
* _PyTime_GetPerfCounterWithInfo()
* _PyTime_MulDiv()
@vstinner vstinner closed this as completed Jul 2, 2023
@ryancdotorg ryancdotorg mentioned this issue Oct 14, 2023
Open
encukou added a commit to encukou/cpython that referenced this issue Feb 12, 2024
@encukou
pythongh-110850 Partially revert "pythongh-106316: Remove pytime.h he…
8cc4416 
…ader file (python#106317)"

This reverts commit 46d7761,
and returns to the  status quo (3.12).

Tests are left in _testinternalcapi; this sounds appropriate for
underscored functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner