Optimize textwrap.indent()

[methane]

Current code:

def indent(text, prefix, predicate=None):
    """Adds 'prefix' to the beginning of selected lines in 'text'.

    If 'predicate' is provided, 'prefix' will only be added to the lines
    where 'predicate(line)' is True. If 'predicate' is not provided,
    it will default to adding 'prefix' to all non-empty lines that do not
    consist solely of whitespace characters.
    """
    if predicate is None:
        def predicate(line):
            return line.strip()

    def prefixed_lines():
        for line in text.splitlines(True):
            yield (prefix + line if predicate(line) else line)
    return ''.join(prefixed_lines())

• predicate = str.strip is faster than def predicate(line)
• ''.join(x) converts input iterable to sequence. Using generator just makes overhead.
• creating temporary prefix + line is avoidable.

Linked PRs

• gh-107369: optimize textwrap.indent() #107374

[methane]

import timeit
import textwrap

with open("Objects/unicodeobject.c") as f:
    text = f.read()

it = timeit.Timer(lambda: textwrap.indent(text, " "*4))
result = it.repeat(number=1000)
result.sort()
print(f"indent {len(text.splitlines())} lines.")
print(f"{result[0]:.4f}msec")

before: 2.8msec
after: 2.1msec (-25%)