Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend netlink support to FreeBSD #107812

Closed
igalic opened this issue Aug 9, 2023 · 4 comments
Closed

Extend netlink support to FreeBSD #107812

igalic opened this issue Aug 9, 2023 · 4 comments
Labels
OS-freebsd triaged The issue has been accepted as valid by a triager. type-feature A feature request or enhancement

Comments

@igalic
Copy link
Contributor

igalic commented Aug 9, 2023

Feature or enhancement

Extend socket's AF_NETLINK support to FreeBSD.

Pitch

FreeBSD 13.2-RELEASE was the first FreeBSD release with a solid support of netlink.
Previously this was Linux only technology, but has established itself as a standard: https://www.rfc-editor.org/rfc/rfc3549

Previous discussion

This is all pretty new, so I am unaware of previous discussions.

Linked PRs

@igalic igalic added the type-feature A feature request or enhancement label Aug 9, 2023
@Eclips4 Eclips4 added OS-freebsd triaged The issue has been accepted as valid by a triager. labels Aug 9, 2023
igalic added a commit to igalic/cpython that referenced this issue Aug 9, 2023
on FreeBSD, netlink.h lives under netlink.
Extend the AC_HEADER_CHECK to look there as well.
igalic added a commit to igalic/cpython that referenced this issue Aug 9, 2023
on FreeBSD, netlink.h lives under netlink.
Extend the AC_HEADER_CHECK to look there as well.
@igalic
Copy link
Contributor Author

igalic commented Aug 10, 2023

is there any way to get this packported to 3.12 at least, so FreeBSD ports won't have to carry this patch for the next couple years?


the python team is preparing a bump to 3.10 right now, which is marked as security release https://www.python.org/downloads/ and since this isn't a bug fix, it can't go into 3.11

but 3.12 isn't out yet do I'm hoping we can backport it there at least

@Eclips4
Copy link
Member

Eclips4 commented Aug 10, 2023

is there any way to get this packported to 3.12 at least, so FreeBSD ports won't have to carry this patch for the next couple years?

the python team is preparing a bump to 3.10 right now, which is marked as security release https://www.python.org/downloads/ and since this isn't a bug fix, it can't go into 3.11

but 3.12 isn't out yet do I'm hoping we can backport it there at least

Perhaps it's a good idea, but 3.12 currently in the stage of "feature freeze", so 3.12 branch accepts only bug fixes and some other stuff with approve of release manager.
cc @Yhg1s

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 10, 2023

[...] but 3.12 currently in the stage of "feature freeze", so 3.12 branch accepts only bug fixes and some other stuff with approve of release manager.

3.12 has entered the Release Candidate phase; nothing goes into 3.12 without RM approval. IMO this is out of the question for 3.12; the FreeBSD ports will have to maintain their patches for another release. (That should not be too hard for them; there has been no other requests for it so far, so I find it hard to see that this is a major pain point.)

igalic added a commit to igalic/cpython that referenced this issue Aug 10, 2023
@Yhg1s
Copy link
Member

Yhg1s commented Aug 11, 2023

Yes, it's too late for 3.12. Feature freeze was back in May, and although I might have let in a change like this one in one of the early betas, it's much too late to include now.

vishwin pushed a commit to vishwin/freebsd-ports that referenced this issue Feb 1, 2024
this patch backports GH-107812: extend socket's netlink support to FreeBSD
see python/cpython#107813
for the patch.

see python/cpython#107812
for the discussion on the backport itself.

Sponsored by: The FreeBSD Foundation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-freebsd triaged The issue has been accepted as valid by a triager. type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants