Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_python.bat is not properly silenced #107814

Closed
maxbachmann opened this issue Aug 9, 2023 · 1 comment
Closed

find_python.bat is not properly silenced #107814

maxbachmann opened this issue Aug 9, 2023 · 1 comment
Labels
OS-windows triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error

Comments

@maxbachmann
Copy link
Contributor

maxbachmann commented Aug 9, 2023 •
edited by bedevere-bot

Bug report

When find_python.bat is run without a Python interpreter present on the system it installs an interpreter via nuget. However in this case it does not properly silence output to stdout when -q is passed. This leads to issues when the user relies on only the interpreter path to be printed, which is the case when it is used inside visual studio.

Linked PRs
@maxbachmann maxbachmann added the type-bug An unexpected behavior, bug, or error label Aug 9, 2023
@bedevere-bot bedevere-bot mentioned this issue Aug 9, 2023
Merged
@Eclips4 Eclips4 added OS-windows triaged The issue has been accepted as valid by a triager. labels Aug 9, 2023
zooba pushed a commit that referenced this issue Aug 9, 2023
@maxbachmann
gh-107814: Avoid output from Nuget installation in find_python.bat (G…
1e229e2 
…H-107815)
@bedevere-bot bedevere-bot mentioned this issue Aug 9, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 9, 2023
@maxbachmann @miss-islington
pythongh-107814: Avoid output from Nuget installation in find_python.…
9e12fc5 
…bat (pythonGH-107815)

(cherry picked from commit 1e229e2)

Co-authored-by: Max Bachmann <kontakt@maxbachmann.de>
@bedevere-bot bedevere-bot mentioned this issue Aug 9, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 9, 2023
@maxbachmann @miss-islington
pythongh-107814: Avoid output from Nuget installation in find_python.…
70134b9 
…bat (pythonGH-107815)

(cherry picked from commit 1e229e2)

Co-authored-by: Max Bachmann <kontakt@maxbachmann.de>
@zooba
Copy link
Member

zooba commented Aug 9, 2023

Thanks! The backports should get merged sometime soon, but I'll close the issue now.

@zooba zooba closed this as completed Aug 9, 2023
zooba pushed a commit that referenced this issue Aug 9, 2023
@miss-islington @maxbachmann
[3.11] gh-107814: Avoid output from Nuget installation in find_python…
eff2042 
….bat (GH-107815)

gh-107814: Avoid output from Nuget installation in find_python.bat (GH-107815)
(cherry picked from commit 1e229e2)

Co-authored-by: Max Bachmann <kontakt@maxbachmann.de>
Yhg1s pushed a commit that referenced this issue Aug 10, 2023
@miss-islington @maxbachmann
[3.12] gh-107814: Avoid output from Nuget installation in find_python…
a71500c 
….bat (GH-107815) (#107823)

gh-107814: Avoid output from Nuget installation in find_python.bat (GH-107815)
(cherry picked from commit 1e229e2)

Co-authored-by: Max Bachmann <kontakt@maxbachmann.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zooba @maxbachmann @Eclips4