Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CFBundleAllowMixedLocalizations property list key inside Info.plist in macOS #108269

Closed
shyamnathp opened this issue Aug 22, 2023 · 8 comments
Assignees
Labels
OS-mac type-feature A feature request or enhancement

Comments

@shyamnathp
Copy link

shyamnathp commented Aug 22, 2023

Feature or enhancement

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Proposal:

Feature Request

The QLocale module of Python packages like PySide6 and PyQt6, incorporates a notion of locale on macOS that extends beyond the POSIX locale (used by the locale Python module) and depends on the Info.plist of the application bundle. This is because both PySide6 and PyQt6 are python bindings to the C++ Qt framework, where every application is compiIed and will be mostly built as a framework, and have its own Info.plist file.

In the case of Python, the application bundle is Python macOS application framework and this module looks at the CFBundleDevelopmentRegion property key inside the Info.plist file of the Python framework (generally in /Library/Frameworks/Python.framework/Versions/3.11/Resources/Python.app/Contents/Info.plist), which is always English. Therefore, even when the system language is something different, QLocale always returns English as the system language. In order to support the retrieval of localized strings, CFBundleAllowMixedLocalizations property key must be turned on in Python's Info.plist.

In the case of non-framework builds of Python, the locale reverts back to the POSIX locale. However, the Python installed by default in macOS and available for install from https://www.python.org/downloads/ are all framework builds.

Corresponding bug in PYSIDE: https://bugreports.qt.io/browse/PYSIDE-2419

Solution

The solution is pretty simple and only includes adding the following line

<key>CFBundleAllowMixedLocalizations</key><true/>

to CPython's Info.plist file. Afaik, the additon of this does not cause any issues elsewhere as well.

I would be happy to make this change myself and contribute to CPython, if you all agree with the idea.

Linked PRs

@shyamnathp shyamnathp added the type-feature A feature request or enhancement label Aug 22, 2023
@torarnv
Copy link

torarnv commented Aug 22, 2023

Note, both application bundles and non-application-bundle builds of the python executable can embed an Info.plist file. The latter is done by passing -sectcreate __TEXT __info_plist /path/to/Info.plist to the linker.

@ediosyncratic
Copy link

Just to clarify: in C++, on Darwin, QLocale calls CFLocaleGetValue() for keys kCFLocale{Language,Script,Country}Code to determine the language script and currency for the system locale, without consulting the environment variables POSIX defines for control of L10n, LANG, LC_* and LANGUAGE. When the Info.plist is suitably configured, this (and other calls QLocale uses to determine system settings) picks up the system L10n settings the user has configured via the system settings app. In particular, when the Info.plist is suitably configured, this lets QLocale::system() reflect user-configured departures from the standard CLDR L10n settings for their language, script and territory. If I understand correctly, python's locale module consults the environment variables instead, which will get it sensible enough results in many situations, but without any user customisation.

@ned-deily ned-deily self-assigned this Aug 22, 2023
qtprojectorg pushed a commit to qtproject/pyside-pyside-setup that referenced this issue Aug 25, 2023
- QSystemLocale for macOS relies on CFBundleAllowMixedLocalizations/
  CFBundleLocalizations in the Info.plist file for the C++
  Application bundle, as seen from
  1d3ae5f0e98f252214d20ce8561533891311a71f. Python being an
  interpreted language, there is no application bundle unless the
  application is deployed. As such a Python application in macOS
  relies on the Info.plist file of the Python interepreter. This
  Info.plist file is a read-only file and hence it is not
  possible/recommended to patch the Info.plist file of the Python
  interpreter at runtime.
  The issue has been raised upstream in CPython and can be tracked
  here: python/cpython#108269

- A possible solution/hack is therefore to use to POSIX environment
  variables for macOS, for Qt for Python. This is also what the Python
  locale module does.
  See: https://github.com/python/cpython/blob/3.11/Lib/locale.py#L534

  For other Unix systems, QLocale::system() uses the POSIX environment
  variables, just like Python's locale module.

- For Windows and Linux, QSystem::locale() remains unchanged.

- The idea here is to obtain the system locale from the Python locale
  module, and use the result to initialize and return a QLocale
  object.

- As an extra, for qrunnable_create fix the typo - snipped to
  snippet.

Fixes: PYSIDE-2419
Pick-to: 6.5 6.2
Change-Id: I12b16e824ddba21d1ebcd0695262c1dc0cc61eb2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
qtprojectorg pushed a commit to qtproject/pyside-pyside-setup that referenced this issue Aug 25, 2023
- QSystemLocale for macOS relies on CFBundleAllowMixedLocalizations/
  CFBundleLocalizations in the Info.plist file for the C++
  Application bundle, as seen from
  1d3ae5f0e98f252214d20ce8561533891311a71f. Python being an
  interpreted language, there is no application bundle unless the
  application is deployed. As such a Python application in macOS
  relies on the Info.plist file of the Python interepreter. This
  Info.plist file is a read-only file and hence it is not
  possible/recommended to patch the Info.plist file of the Python
  interpreter at runtime.
  The issue has been raised upstream in CPython and can be tracked
  here: python/cpython#108269

- A possible solution/hack is therefore to use to POSIX environment
  variables for macOS, for Qt for Python. This is also what the Python
  locale module does.
  See: https://github.com/python/cpython/blob/3.11/Lib/locale.py#L534

  For other Unix systems, QLocale::system() uses the POSIX environment
  variables, just like Python's locale module.

- For Windows and Linux, QSystem::locale() remains unchanged.

- The idea here is to obtain the system locale from the Python locale
  module, and use the result to initialize and return a QLocale
  object.

- As an extra, for qrunnable_create fix the typo - snipped to
  snippet.

Fixes: PYSIDE-2419
Change-Id: I12b16e824ddba21d1ebcd0695262c1dc0cc61eb2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit 35c9611)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
@ronaldoussoren
Copy link
Contributor

How can reproduce the issue? That is, is there a script that I can use that gives the wrong result without the proposed change (installing PyQt or PySide for this is no problem)?

@ronaldoussoren
Copy link
Contributor

I've set my system to dutch as the primary language with English as a fallback. After installing PySide6:

from PySide6.QtCore import QLocale
>>> QLocale()
<PySide6.QtCore.QLocale(English, Default, Netherlands) at 0x103278ec0>

Adding <key>CFBundleAllowMixedLocalizations</key><true/> to .../Resources/Python.app/Info.plist:

>>> from PySide6.QtCore import QLocale
>>> QLocale()
<PySide6.QtCore.QLocale(Dutch, Default, Netherlands) at 0x1005f0e40>

ronaldoussoren added a commit to ronaldoussoren/cpython that referenced this issue Dec 16, 2023
… macOS

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
@ronaldoussoren
Copy link
Contributor

The attached PR changes all 3 Info.plists we ship to be consistent, the change to the Info.plist in IDLE likely isn't necessary whereas the Python.app change definitely is and the framework change likely affects command-line tools linking to the framework.

@shyamnathp
Copy link
Author

Thanks for fixing this @ronaldoussoren

ned-deily pushed a commit that referenced this issue Dec 18, 2023
…GH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
@ned-deily
Copy link
Member

I merged the PR to main for 3.13.0a3. I'll leave the issue open to decide about backporting.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 19, 2023
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
(cherry picked from commit 4cfce3a)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren added a commit that referenced this issue Dec 19, 2023
…n macOS (GH-113213) (#113294)

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS (GH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
(cherry picked from commit 4cfce3a)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@ronaldoussoren
Copy link
Contributor

I've been conservative with back porting and only back ported to 3.12, primarily because I'm not sure in what circumstances this might break existing code on upgrade and because I expect that GUI code will often be distributed in app bundles using tools like pyinstaller and py2app where its easy enough to add the right flag to the app info.plist.

ryan-duve pushed a commit to ryan-duve/cpython that referenced this issue Dec 26, 2023
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

6 participants