Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for msvcrt module #108996

Closed
aisk opened this issue Sep 6, 2023 · 3 comments
Closed

Add tests for msvcrt module #108996

aisk opened this issue Sep 6, 2023 · 3 comments
Labels
OS-windows tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@aisk
Copy link
Member

aisk commented Sep 6, 2023 •
edited by bedevere-bot

Bug report

Bug description:

msvcrt is a public module, but it has no tests.

Linked PRs
@aisk aisk added the type-bug An unexpected behavior, bug, or error label Sep 6, 2023
@AlexWaygood AlexWaygood added the tests Tests in the Lib/test dir label Sep 6, 2023
aisk added a commit to aisk/cpython that referenced this issue Sep 6, 2023
@aisk
pythongh-108996: add tests for msvcrt
8845629
@bedevere-bot bedevere-bot mentioned this issue Sep 6, 2023
Merged
@AlexWaygood AlexWaygood changed the title msvcrt module have no tests msvcrt module has no tests Sep 6, 2023
@terryjreedy terryjreedy changed the title msvcrt module has no tests Add tests for msvcrt module Sep 6, 2023
@terryjreedy
Copy link
Member

Thanks for the submission. I reviewed the PR but would like someone else to look at the file op class.

terryjreedy added a commit that referenced this issue Sep 8, 2023
@aisk @terryjreedy @zooba
gh-108996: add tests for msvcrt (#109004)
bcb2ab5 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 8, 2023
@aisk @terryjreedy
@zooba @miss-islington
pythongh-108996: add tests for msvcrt (pythonGH-109004)
3899877 
(cherry picked from commit bcb2ab5)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 8, 2023
@aisk @terryjreedy
@zooba @miss-islington
pythongh-108996: add tests for msvcrt (pythonGH-109004)
6269b37 
(cherry picked from commit bcb2ab5)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
vstinner added a commit to vstinner/cpython that referenced this issue Sep 8, 2023
@vstinner
pythongh-108996: Skip broken test_msvcrt for now
626a0cf
@bedevere-bot bedevere-bot mentioned this issue Sep 8, 2023
Merged
vstinner added a commit that referenced this issue Sep 8, 2023
@vstinner
gh-108996: Skip broken test_msvcrt for now (#109169)
2fafc3d
aisk added a commit to aisk/cpython that referenced this issue Sep 10, 2023
@aisk
pythongh-108996: fix and enable test_msvcrt
c8d3c3f
@bedevere-bot bedevere-bot mentioned this issue Sep 10, 2023
Merged
vstinner pushed a commit that referenced this issue Sep 22, 2023
@aisk
gh-108996: fix and enable test_msvcrt (#109226)
4230d7c 
* Add _testconsole.flush_console_input_buffer() function.
* test_kbhit(), test_getwch() and test_getwche() now call
  flush_console_input_buffer().
* Don't override sys.stdin anymore (not needed).
@vstinner
Copy link
Member

I close the issue, thanks @aisk.

csm10495 pushed a commit to csm10495/cpython that referenced this issue Sep 28, 2023
@aisk @csm10495
pythongh-108996: fix and enable test_msvcrt (python#109226)
8e0eaa7 
* Add _testconsole.flush_console_input_buffer() function.
* test_kbhit(), test_getwch() and test_getwche() now call
  flush_console_input_buffer().
* Don't override sys.stdin anymore (not needed).
@vstinner
Copy link
Member

test_msvcrt: test_getwche() failed with timeout (10 min) on GHA Windows x64: see issue gh-110147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @aisk @terryjreedy @AlexWaygood