Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regrtest: python -m test -j1 --verbose3 should not replace sys.stdout #110367

Closed
vstinner opened this issue Oct 4, 2023 · 0 comments
Closed

regrtest: python -m test -j1 --verbose3 should not replace sys.stdout #110367

vstinner opened this issue Oct 4, 2023 · 0 comments

Comments

@vstinner
Copy link
Member

vstinner commented Oct 4, 2023 •
edited by bedevere-app bot

Currently, when a test does crash, its output is lost. It gives bug reports like issue gh-110364 which contains no output, just an exit code :-( The problem is that run_single_test() replaces sys.stdout when --verbose3 option is used. If Python runs normally, the output is ignored on success, or display on error.

When we run a worker process, we can make this decision in the main process: ignore the output on error, or display the output on error.

Linked PRs
vstinner added a commit to vstinner/cpython that referenced this issue Oct 4, 2023
@vstinner
pythongh-110367: Enhance regrtest -jN --verbose3
77afa75 
When using worker processes (-jN), regrtest no longer replaces
sys.stdout in the worker process when running run_single_test().
Instead, RunWorkers only shows the worker stdout if the test result
is not a success.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 4, 2023
@vstinner
pythongh-110367: Enhance regrtest -jN --verbose3
9112bc3 
When using worker processes (-jN) with --verbose3 option, regrtest
can now display the worker output even if a worker process does
crash.  Previously, sys.stdout and sys.stderr were replaced and so
the worker output was lost on a crash.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 4, 2023
@vstinner
pythongh-110367: Enhance regrtest -jN --verbose3
4c46843 
When using worker processes (-jN) with --verbose3 option, regrtest
can now display the worker output even if a worker process does
crash.  Previously, sys.stdout and sys.stderr were replaced and so
the worker output was lost on a crash.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 4, 2023
@vstinner
pythongh-110367: Enhance regrtest -jN --verbose3
06c3e31 
When using worker processes (-jN) with --verbose3 option, regrtest
can now display the worker output even if a worker process does
crash.  Previously, sys.stdout and sys.stderr were replaced and so
the worker output was lost on a crash.
@bedevere-app bedevere-app bot mentioned this issue Oct 4, 2023
Merged
vstinner added a commit that referenced this issue Oct 5, 2023
@vstinner
gh-110367: Enhance regrtest -jN --verbose3 (#110368)
6592976 
When using worker processes (-jN) with --verbose3 option, regrtest
can now display the worker output even if a worker process does
crash.  Previously, sys.stdout and sys.stderr were replaced and so
the worker output was lost on a crash.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 5, 2023
@vstinner
pythongh-110367: Fix regrtest test_worker_output_on_failure() on ASAN…
56a3086 
… build

Set ASAN_OPTIONS="handle_segv=0" env var to run the test.
@bedevere-app bedevere-app bot mentioned this issue Oct 5, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 5, 2023
@vstinner
pythongh-110367: Fix regrtest test_worker_output_on_failure() on ASAN…
a822772 
… build

Set ASAN_OPTIONS="handle_segv=0" env var to run the test.
vstinner added a commit that referenced this issue Oct 5, 2023
@vstinner
gh-110367: Fix regrtest test_worker_output_on_failure() on ASAN build (…
af29282 
…#110387)

Set ASAN_OPTIONS="handle_segv=0" env var to run the test.
@vstinner vstinner closed this as completed Oct 5, 2023
@vstinner vstinner mentioned this issue Oct 5, 2023
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Oct 31, 2023
@vstinner
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
27b601c 
…s -jN

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 31, 2023
@vstinner
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
00c18da 
…s -jN

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 31, 2023
@vstinner
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
ec8f37e 
…s -jN

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
@bedevere-app bedevere-app bot mentioned this issue Oct 31, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Nov 1, 2023
@vstinner
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
687f60e 
…s -jN

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
vstinner added a commit that referenced this issue Nov 1, 2023
@vstinner
gh-110367: Make regrtest --verbose3 compatible with --huntrleaks -jN (#…
d9a5530 
…111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 1, 2023
@vstinner @miss-islington
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
4db0065 
…s -jN (pythonGH-111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
(cherry picked from commit d9a5530)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot mentioned this issue Nov 1, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 1, 2023
@vstinner @miss-islington
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
9db68dd 
…s -jN (pythonGH-111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
(cherry picked from commit d9a5530)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot mentioned this issue Nov 1, 2023
Merged
vstinner added a commit that referenced this issue Nov 1, 2023
@miss-islington @vstinner
[3.12] gh-110367: Make regrtest --verbose3 compatible with --huntrlea…
2162512 
…ks -jN (GH-111577) (#111589)

gh-110367: Make regrtest --verbose3 compatible with --huntrleaks -jN (GH-111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
(cherry picked from commit d9a5530)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this issue Nov 1, 2023
@miss-islington @vstinner
[3.11] gh-110367: Make regrtest --verbose3 compatible with --huntrlea…
1d7ad77 
…ks -jN (GH-111577) (#111590)

gh-110367: Make regrtest --verbose3 compatible with --huntrleaks -jN (GH-111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
(cherry picked from commit d9a5530)

Co-authored-by: Victor Stinner <vstinner@python.org>
FullteaR pushed a commit to FullteaR/cpython that referenced this issue Nov 3, 2023
@vstinner @FullteaR
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
901b7fb 
…s -jN (python#111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@vstinner @aisk
pythongh-110367: Make regrtest --verbose3 compatible with --huntrleak…
856e654 
…s -jN (python#111577)

"./python -m test -j1 -R 3:3 --verbose3" now works as expected, since
run_single_test() does not replace sys.stdout with StringIO in this
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner