Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tty module is not tested #110388

Closed
serhiy-storchaka opened this issue Oct 5, 2023 · 0 comments
Closed

The tty module is not tested #110388

serhiy-storchaka opened this issue Oct 5, 2023 · 0 comments
Assignees
@serhiy-storchaka
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 5, 2023 •
edited by bedevere-app bot

It only contains 4 functions (2 before 3.12). tty.setcbreak() is only used in pydoc (and this case seems is not tested), tty.setraw() is only used in pty and tests mock it. So, the tty module is not tested, neither directly, nor indirectly.

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes labels Oct 5, 2023
@serhiy-storchaka serhiy-storchaka self-assigned this Oct 5, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 5, 2023
@serhiy-storchaka
pythongh-110388: Add tests for tty
bb70322
@bedevere-app bedevere-app bot mentioned this issue Oct 5, 2023
Merged
ambv pushed a commit that referenced this issue Oct 10, 2023
@serhiy-storchaka
gh-110388: Add tests for tty (GH-110394)
7f702b2
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 10, 2023
@serhiy-storchaka @miss-islington
pythongh-110388: Add tests for tty (pythonGH-110394)
e575fbe 
(cherry picked from commit 7f702b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 10, 2023
@serhiy-storchaka @miss-islington
pythongh-110388: Add tests for tty (pythonGH-110394)
6e81355 
(cherry picked from commit 7f702b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Oct 10, 2023
Merged
Closed
ambv pushed a commit that referenced this issue Oct 10, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-110388: Add tests for tty (GH-110394) (#110621)
43641f5 
cherry picked from commit 7f702b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 10, 2023
@serhiy-storchaka
[3.11] pythongh-110388: Add tests for tty (pythonGH-110394)
73b3d33 
(cherry picked from commit 7f702b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 10, 2023
@serhiy-storchaka
[3.11] pythongh-110388: Add tests for tty (pythonGH-110394)
fc6101b 
(cherry picked from commit 7f702b2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 10, 2023
Merged
ambv pushed a commit that referenced this issue Oct 10, 2023
@serhiy-storchaka
[3.11] gh-110388: Add tests for tty (GH-110394) (GH-110634)
3788c48 
(cherry picked from commit 7f702b2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka