Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning for non-integer number in gettext is not always accurate #110519

Closed
serhiy-storchaka opened this issue Oct 8, 2023 · 0 comments
Closed

Deprecation warning for non-integer number in gettext is not always accurate #110519

serhiy-storchaka opened this issue Oct 8, 2023 · 0 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 8, 2023 •
edited by bedevere-app bot

Bug report

gettext functions and methods that consider plural forms (like ngettext()) and directly or indirectly use GNUTranslations emit a deprecation warning if the number is not integer. But it only points to the line where GNUTranslations methods ngettext() or npgettext() are used directly. Since module level functions use it indirectly, and methods of other classes can use it indirectly as a fallback, the deprecation warning usually points to the line in the gettext module instead of the line in the user code that uses it. It makes deprecation warnings much less useful.

The following PR dynamically calculate the stacklevel for warning, skipping any gettext code.

Also I have found that many code is not covered by tests (in particular NullTranslations and domain-aware functions like dngettext()). The PR extends tests.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error 3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes labels Oct 8, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Oct 8, 2023
@serhiy-storchaka
pythongh-110519: Improve deprecation warning in the gettext module
049bbae 
Deprecation warning about non-integer number in gettext now alwais refers
to the line in the user code where gettext function or method is used.
Previously it could refer to a line in gettext code.

Also, increase test coverage for NullTranslations and domain-aware functions
like dngettext().
@bedevere-app bedevere-app bot mentioned this issue Oct 8, 2023
Merged
@serhiy-storchaka serhiy-storchaka mentioned this issue Oct 8, 2023
Closed
This was referenced Oct 9, 2023
Merged
Merged
ambv pushed a commit that referenced this issue Oct 9, 2023
@serhiy-storchaka
gh-110519: Improve deprecation warning in the gettext module (#110520)
326c6c4 
Deprecation warning about non-integer numbers in gettext now always refers
to the line in the user code where gettext function or method is used.
Previously, it could refer to a line in gettext code.

Also, increase test coverage for NullTranslations and domain-aware functions
like dngettext().
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 9, 2023
@serhiy-storchaka @miss-islington
pythongh-110519: Improve deprecation warning in the gettext module (p…
5f787d2 
…ythonGH-110520)

Deprecation warning about non-integer numbers in gettext now always refers
to the line in the user code where gettext function or method is used.
Previously, it could refer to a line in gettext code.

Also, increase test coverage for NullTranslations and domain-aware functions
like dngettext().
(cherry picked from commit 326c6c4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 9, 2023
@serhiy-storchaka @miss-islington
pythongh-110519: Improve deprecation warning in the gettext module (p…
a2c7160 
…ythonGH-110520)

Deprecation warning about non-integer numbers in gettext now always refers
to the line in the user code where gettext function or method is used.
Previously, it could refer to a line in gettext code.

Also, increase test coverage for NullTranslations and domain-aware functions
like dngettext().
(cherry picked from commit 326c6c4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this issue Oct 9, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-110519: Improve deprecation warning in the gettext module (G…
e913c6f 
…H-110520) (GH-110564)

Deprecation warning about non-integer numbers in gettext now always refers
to the line in the user code where gettext function or method is used.
Previously, it could refer to a line in gettext code.

Also, increase test coverage for NullTranslations and domain-aware functions
like dngettext().
(cherry picked from commit 326c6c4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ambv pushed a commit that referenced this issue Oct 9, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-110519: Improve deprecation warning in the gettext module (G…
1f43bc2 
…H-110520) (GH-110563)

Deprecation warning about non-integer numbers in gettext now always refers
to the line in the user code where gettext function or method is used.
Previously, it could refer to a line in gettext code.

Also, increase test coverage for NullTranslations and domain-aware functions
like dngettext().
(cherry picked from commit 326c6c4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
Gettext issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka