Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in math_sumprod_impl() #111342

Closed
skirpichev opened this issue Oct 26, 2023 · 2 comments
Closed

Typo in math_sumprod_impl() #111342

skirpichev opened this issue Oct 26, 2023 · 2 comments

Comments

@skirpichev
Copy link
Contributor

skirpichev commented Oct 26, 2023 •
edited by bedevere-app bot

cpython/Modules/mathmodule.c

Line 2835 in 3f84a19

} else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) {

Obviously, should be p_i in the last OR operand, c.f. L2824.

Factored out from #110000. I think this should be fixed regardless on the fate of that pr. 052d7de has also simple test for this if.

Linked PRs
@rhettinger
Copy link
Contributor

@skirpichev Care to make a PR with test for this?

skirpichev added a commit to skirpichev/cpython that referenced this issue Oct 28, 2023
@skirpichev
pythongh-111342: fix typo in math.sumprod
b24fc2e
@bedevere-app bedevere-app bot mentioned this issue Oct 28, 2023
Merged
@skirpichev
Copy link
Contributor Author

Yep. #111416

@bedevere-app bedevere-app bot mentioned this issue Oct 28, 2023
Merged
rhettinger pushed a commit that referenced this issue Oct 28, 2023
@skirpichev
gh-111342: fix typo in math.sumprod (GH-111416)
9dc4fb8
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 28, 2023
@skirpichev @miss-islington
pythongh-111342: fix typo in math.sumprod (pythonGH-111416)
5d8d11a 
(cherry picked from commit 9dc4fb8)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
rhettinger pushed a commit that referenced this issue Oct 28, 2023
@miss-islington
[3.12] gh-111342: fix typo in math.sumprod (GH-111416) (gh-111419)
c3f75b7
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Oct 29, 2023
@skirpichev @iritkatriel
pythongh-111342: fix typo in math.sumprod (pythonGH-111416)
1b70f83
@skirpichev skirpichev mentioned this issue Nov 3, 2023
Draft
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@skirpichev @aisk
pythongh-111342: fix typo in math.sumprod (pythonGH-111416)
5d7f466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhettinger @skirpichev