Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hacks in genobject.c #111354

Closed
iritkatriel opened this issue Oct 26, 2023 · 1 comment
Closed

remove hacks in genobject.c #111354

iritkatriel opened this issue Oct 26, 2023 · 1 comment
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Oct 26, 2023

Refactor Objects/genobject.c to get rid of these hacks/issues:

  • gen_close accesses instr_ptr - 1
  • _PyGen_yf peeks into the execution stack
  • Comparisons with enum values
  • result arg reused in gen_send_ex2 for two different purposes (one of which is not the result)

Linked PRs

@iritkatriel iritkatriel self-assigned this Oct 26, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Oct 26, 2023
@iritkatriel iritkatriel changed the title hacks in gen_close remove hacks in gen_close Oct 26, 2023
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Oct 26, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Nov 2, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this issue Nov 3, 2023
iritkatriel added a commit that referenced this issue Nov 3, 2023
@iritkatriel iritkatriel changed the title remove hacks in gen_close remove hacks in genobject.c Nov 3, 2023
iritkatriel added a commit that referenced this issue Nov 9, 2023
@hugovk
Copy link
Member

hugovk commented Nov 9, 2023

Closing as it looks like the relevant PRs have been merged, please re-open if still needed.

@hugovk hugovk closed this as completed Nov 9, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

No branches or pull requests

2 participants