Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/library/sqlite3.rst has multiple doctest warnings #111726

Open
sobolevn opened this issue Nov 4, 2023 · 0 comments
Open

Doc/library/sqlite3.rst has multiple doctest warnings #111726

sobolevn opened this issue Nov 4, 2023 · 0 comments
Assignees
@sobolevn
Labels
docs Documentation in the Doc dir tests Tests in the Lib/test dir topic-sqlite3 type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Nov 4, 2023 •
edited by bedevere-app bot

Bug report

Link: https://github.com/python/cpython/actions/runs/6753865568/job/18360794210?pr=111723#step:8:82

Document: library/sqlite3
-------------------------
Exception ignored in: <sqlite3.Connection object at 0x7f1684307130>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f1684307130>
Exception ignored in: <sqlite3.Connection object at 0x7f1684307ac0>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f1684307ac0>
Exception ignored in: <sqlite3.Connection object at 0x7f16891eb680>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891eb680>
Exception ignored in: <sqlite3.Connection object at 0x7f16891eb240>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891eb240>
Exception ignored in: <sqlite3.Connection object at 0x7f16891ea9c0>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891ea9c0>
Exception ignored in: <sqlite3.Connection object at 0x7f16891eb350>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891eb350>
Exception ignored in: <sqlite3.Connection object at 0x7f16891eb130>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891eb130>
Exception ignored in: <sqlite3.Connection object at 0x7f16891ea8b0>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891ea8b0>
Exception ignored in: <sqlite3.Connection object at 0x7f16891e9bf0>
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/functools.py", line 55, in update_wrapper
    pass
ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7f16891e9bf0>
4 items passed all tests:
  71 tests in default
   3 tests in sqlite3.cursor
   3 tests in sqlite3.limits
   8 tests in sqlite3.trace
85 tests in 4 items.
85 passed and 0 failed.
Test passed.
Exception ignored in sys.unraisablehook: <function debug at 0x7f167bb73c50>
Traceback (most recent call last):
  File "<doctest sqlite3.trace[4]>", line 2, in debug
AttributeError: 'sqlite3.Connection' object has no attribute '__name__'
Exception ignored in sys.unraisablehook: <function debug at 0x7f167bb73c50>
Traceback (most recent call last):
  File "<doctest sqlite3.trace[4]>", line 2, in debug
AttributeError: 'sqlite3.Connection' object has no attribute '__name__'
Exception ignored in sys.unraisablehook: <function debug at 0x7f167bb73c50>
Traceback (most recent call last):
  File "<doctest sqlite3.trace[4]>", line 2, in debug
AttributeError: 'sqlite3.Connection' object has no attribute '__name__'
Exception ignored in sys.unraisablehook: <function debug at 0x7f167bb73c50>
Traceback (most recent call last):
  File "<doctest sqlite3.trace[4]>", line 2, in debug
AttributeError: 'sqlite3.Connection' object has no attribute '__name__'
Exception ignored in sys.unraisablehook: <function debug at 0x7f167bb73c50>
Traceback (most recent call last):
  File "<doctest sqlite3.trace[4]>", line 2, in debug
AttributeError: 'sqlite3.Connection' object has no attribute '__name__'

I will examine possible fixes and send a PR.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir docs Documentation in the Doc dir topic-sqlite3 labels Nov 4, 2023
@sobolevn sobolevn self-assigned this Nov 4, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Nov 4, 2023
@sobolevn
pythongh-111726: Fix doctest warnings in Doc/library/sqlite3.rst
3fbdbc7
@bedevere-app bedevere-app bot mentioned this issue Nov 4, 2023
Merged
erlend-aasland pushed a commit that referenced this issue Apr 8, 2024
@hugovk
gh-111726: Cleanup test files after running sqlite3 doctest (#117604)
a453f5e 
Remove all temporary databases in a dedicated 'testcleanup' step
at the end of the file.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 8, 2024
@hugovk @miss-islington
pythongh-111726: Cleanup test files after running sqlite3 doctest (py…
0f45640 
…thonGH-117604)

Remove all temporary databases in a dedicated 'testcleanup' step
at the end of the file.
(cherry picked from commit a453f5e)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Apr 8, 2024
Merged
erlend-aasland pushed a commit that referenced this issue Apr 8, 2024
@miss-islington @hugovk
[3.12] gh-111726: Cleanup test files after running sqlite3 doctest (G…
e9a49c2 
…H-117604) (#117622)

Remove all temporary databases in a dedicated 'testcleanup' step
at the end of the file.
(cherry picked from commit a453f5e)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Apr 8, 2024
Merged
erlend-aasland added a commit that referenced this issue Apr 8, 2024
@erlend-aasland
gh-111726: Remove some doctests from sqlite3 docs (#117623)
e338e1a 
* remove load extension doctest since we cannot skip it conditionally
* remove sys.unraisablehook example; using unraisable hooks is not "an
  improved debug experience"
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 8, 2024
@erlend-aasland @miss-islington
pythongh-111726: Remove some doctests from sqlite3 docs (pythonGH-117623
b9c7883 
)

* remove load extension doctest since we cannot skip it conditionally
* remove sys.unraisablehook example; using unraisable hooks is not "an
  improved debug experience"
(cherry picked from commit e338e1a)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app bedevere-app bot mentioned this issue Apr 8, 2024
Merged
erlend-aasland added a commit that referenced this issue Apr 8, 2024
@miss-islington @erlend-aasland
[3.12] gh-111726: Remove some doctests from sqlite3 docs (GH-117623) (#…
7374d65 
…117625)

* remove load extension doctest since we cannot skip it conditionally
* remove sys.unraisablehook example; using unraisable hooks is not "an
  improved debug experience"

(cherry picked from commit e338e1a)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this issue Apr 8, 2024
@sobolevn @erlend-aasland
gh-111726: Explicitly close database connections in sqlite3 doctests (#…
a770266 
…111730)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 8, 2024
@sobolevn @erlend-aasland @miss-islington
pythongh-111726: Explicitly close database connections in sqlite3 doc…
b1bfeae 
…tests (pythonGH-111730)

(cherry picked from commit a770266)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app bedevere-app bot mentioned this issue Apr 8, 2024
Merged
erlend-aasland added a commit that referenced this issue Apr 8, 2024
@miss-islington @sobolevn @erlend-aasland
[3.12] gh-111726: Explicitly close database connections in sqlite3 do…
ced3598 
…ctests (GH-111730) (#117630)

(cherry picked from commit a770266)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@hugovk @diegorusso
pythongh-111726: Cleanup test files after running sqlite3 doctest (py…
e5832fa 
…thon#117604)

Remove all temporary databases in a dedicated 'testcleanup' step
at the end of the file.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-111726: Remove some doctests from sqlite3 docs (python#117623)
d3185bf 
* remove load extension doctest since we cannot skip it conditionally
* remove sys.unraisablehook example; using unraisable hooks is not "an
  improved debug experience"
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @erlend-aasland @diegorusso
pythongh-111726: Explicitly close database connections in sqlite3 doc…
6f60713 
…tests (python#111730)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
docs Documentation in the Doc dir tests Tests in the Lib/test dir topic-sqlite3 type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn