Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextIOWrapper.reconfigure() crashes if encoding is not string or None #111942

Closed
serhiy-storchaka opened this issue Nov 10, 2023 · 2 comments
Closed

TextIOWrapper.reconfigure() crashes if encoding is not string or None #111942

serhiy-storchaka opened this issue Nov 10, 2023 · 2 comments
Assignees
@serhiy-storchaka
Labels
topic-IO type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 10, 2023 •
edited by bedevere-app bot

Crash report

What happened?

Unlike to TextIOWrapper constructor, TextIOWrapper.reconfigure() does not check that the encoding argument is actually None or string. If it is not None, it calls _PyUnicode_EqualToASCIIString that only works with strings and crashes in debug build. There may be other similar errors in other arguments.

>>> import sys
>>> sys.stdout.reconfigure(encoding=42)
Objects/unicodeobject.c:552: _PyUnicode_CheckConsistency: Assertion failed: PyType_HasFeature((Py_TYPE(((PyObject*)((op))))), ((1UL << 28)))
Enable tracemalloc to get the memory block allocation traceback

object address  : 0x55a2e3147ca8
object refcount : 4294967295
object type     : 0x55a2e3119f00
object type name: int
object repr     : 42

Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized

Current thread 0x00007fc99ee43740 (most recent call first):
  File "<stdin>-1", line 1 in <module>
Aborted (core dumped)

CPython versions tested on:

3.10, 3.11, 3.12

Operating systems tested on:

No response

Output from running 'python -VV' on the command line:

No response

Linked PRs
@serhiy-storchaka serhiy-storchaka added topic-IO type-crash A hard crash of the interpreter, possibly with a core dump labels Nov 10, 2023
@serhiy-storchaka serhiy-storchaka self-assigned this Nov 10, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 10, 2023
@serhiy-storchaka
pythongh-111942: Fix crashes in TextIOWrapper.reconfigure()
3d8e144 
* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.
@bedevere-app bedevere-app bot mentioned this issue Nov 10, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Nov 14, 2023
@serhiy-storchaka
gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976)
ee06fff 
* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka @miss-islington
pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…
52d3e54 
…-111976)

* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.
(cherry picked from commit ee06fff)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 14, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka @miss-islington
pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…
c4fc137 
…-111976)

* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.
(cherry picked from commit ee06fff)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 14, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Nov 14, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976…
24216d0 
…) (GH-112058)

* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.

(cherry picked from commit ee06fff)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka
pythongh-111942: Fix crash in the TextIOWrapper constructor
bd438e2 
In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.
@bedevere-app bedevere-app bot mentioned this issue Nov 14, 2023
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka
pythongh-111942: Fix SystemError in the TextIOWrapper constructor
0a85bf3 
In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.
@serhiy-storchaka
Copy link
Member Author

Weird. The address sanitizer tests were passed in main and 3.12, but failed in 3.11. And I now can reproduce the failure locally in main.

The newly added tests exposed a bug in the TextIOWrapper constructor when pass a non-encodable "errors" argument.

vstinner added a commit to vstinner/cpython that referenced this issue Nov 14, 2023
@vstinner
pythongh-111942: Fix test_io test_constructor()
eac3bf5 
The error handler is not tested in the _io extension. It's only
tested if Python is built in debug mode (Py_DEBUG) or if the Python
Development Mode (-X dev) is enabled.
@bedevere-app bedevere-app bot mentioned this issue Nov 14, 2023
Closed
vstinner added a commit that referenced this issue Nov 14, 2023
@serhiy-storchaka @vstinner
gh-111942: Fix SystemError in the TextIOWrapper constructor (#112061)
9302f05 
In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka @vstinner @miss-islington
pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…
8561de9 
…thonGH-112061)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

(cherry picked from commit 9302f05)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Nov 14, 2023
Closed
Merged
vstinner pushed a commit to vstinner/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka @vstinner
pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…
45075b8 
…thon#112061)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 9302f05)
vstinner pushed a commit to vstinner/cpython that referenced this issue Nov 14, 2023
@serhiy-storchaka @vstinner
pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…
7f58ab2 
…thon#112061)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 9302f05)
serhiy-storchaka added a commit that referenced this issue Nov 15, 2023
@vstinner @serhiy-storchaka
[3.12] gh-111942: Fix SystemError in the TextIOWrapper constructor (G…
1445d77 
…H-112061) (GH-112089)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 9302f05)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to miss-islington/cpython that referenced this issue Nov 15, 2023
@vstinner @serhiy-storchaka
[3.12] pythongh-111942: Fix SystemError in the TextIOWrapper construc…
52cafc8 
…tor (pythonGH-112061) (pythonGH-112089)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 9302f05)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Nov 15, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976…
e2421a3 
…) (GH-112059)

* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.

(cherry picked from commit ee06fff)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner
Copy link
Member

Nice thanks, thanks.

aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…
e6d29f1 
…-111976)

* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @vstinner @aisk
pythongh-111942: Fix SystemError in the TextIOWrapper constructor (py…
8d3b7eb 
…thon#112061)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
topic-IO type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @serhiy-storchaka