Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when trying to call issubclass() against a Protocol that has non-method members #112345

Closed
AlexWaygood opened this issue Nov 23, 2023 · 0 comments · Fixed by #112344
Closed

Improve error message when trying to call issubclass() against a Protocol that has non-method members #112345

AlexWaygood opened this issue Nov 23, 2023 · 0 comments · Fixed by #112344
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir topic-typing type-feature A feature request or enhancement

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 23, 2023 •
edited by bedevere-app bot

Feature or enhancement

Proposal:

The error message could tell the user what the non-method members in the protocol are.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@AlexWaygood AlexWaygood added type-feature A feature request or enhancement topic-typing 3.13 bugs and security fixes labels Nov 23, 2023
@bedevere-app bedevere-app bot mentioned this issue Nov 23, 2023
Merged
@AlexWaygood AlexWaygood added the stdlib Python modules in the Lib dir label Nov 23, 2023
AlexWaygood added a commit that referenced this issue Nov 24, 2023
@randolf-scholz @AlexWaygood
gh-112345: typing.Protocol: Let failed subclasscheck show non-metho…
e9d1360 
…d members (#112344)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@randolf-scholz @AlexWaygood @aisk
pythongh-112345: typing.Protocol: Let failed subclasscheck show non…
95e4ddd 
…-method members (python#112344)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes stdlib Python modules in the Lib dir topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-112345: Let failed protocol subclasscheck show non-method members randolf-scholz/cpython
1 participant
@AlexWaygood