Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The perf trampoline can free the jitted code when is still used #112367

Closed
pablogsal opened this issue Nov 24, 2023 · 0 comments
Closed

The perf trampoline can free the jitted code when is still used #112367

pablogsal opened this issue Nov 24, 2023 · 0 comments

Comments

@pablogsal
Copy link
Member

pablogsal commented Nov 24, 2023 •
edited by bedevere-app bot

Deactivating the trampoline frees the code arenas but this can happen when we are under the trampolines themselves so this leads to UB.

Linked PRs
@bedevere-app bedevere-app bot mentioned this issue Nov 24, 2023
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
f06249b 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
fdc69f9
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
dc3c7d8 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
b95e8b5 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
92b61e4 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
d480235 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Nov 24, 2023
@pablogsal
pythongh-112367: Only free perf trampoline arenas at shutdown
41f0cff 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Dec 1, 2023
@pablogsal
gh-112367: Only free perf trampoline arenas at shutdown (#112368)
a73aa48 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Dec 1, 2023
Merged
pablogsal added a commit to pablogsal/cpython that referenced this issue Dec 1, 2023
@pablogsal
[3.12] pythongh-112367: Only free perf trampoline arenas at shutdown (p…
7d330e9 
…ythonGH-112368)

(cherry picked from commit a73aa48)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this issue Dec 1, 2023
@pablogsal
[3.12] pythongh-112367: Only free perf trampoline arenas at shutdown (p…
2d7b611 
…ythonGH-112368)

(cherry picked from commit a73aa48)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Dec 1, 2023
@pablogsal
[3.12] gh-112367: Only free perf trampoline arenas at shutdown (GH-11…
11232c1 
…2368) (#112590)

(cherry picked from commit a73aa48)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@pablogsal @aisk
pythongh-112367: Only free perf trampoline arenas at shutdown (python…
f67c4de 
…#112368)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pablogsal