Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cache information a part of dis.Instruction #112962

Closed
iritkatriel opened this issue Dec 11, 2023 · 0 comments · Fixed by #113016
Closed

Make cache information a part of dis.Instruction #112962

iritkatriel opened this issue Dec 11, 2023 · 0 comments · Fixed by #113016
Assignees
@iritkatriel
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Dec 11, 2023 •
edited by bedevere-app bot

Feature or enhancement

We currently create fake Instruction objects to represent cache entries. It would make more sense to make the cache info part of the Instruction.

This will change the output of dis.get_instructions, but not anything which is documented.

Linked PRs
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Python modules in the Lib dir labels Dec 11, 2023
@iritkatriel iritkatriel self-assigned this Dec 11, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Dec 12, 2023
@iritkatriel
pythongh-112962: in dis module, put cache information in the Instruct…
ae7dbca 
…ion instead of creating fake Instructions to represent it
@iritkatriel iritkatriel mentioned this issue Dec 12, 2023
Merged
iritkatriel added a commit that referenced this issue Dec 13, 2023
@iritkatriel
gh-112962: in dis module, put cache information in the Instruction in…
428c981 
…stead of creating fake Instructions to represent it (#113016)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@iritkatriel @aisk
pythongh-112962: in dis module, put cache information in the Instruct…
a1407ac 
…ion instead of creating fake Instructions to represent it (python#113016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
1 participant
@iritkatriel