Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autoconf to warn when building under wasm32-unknown-emscripten #113632

Closed
brettcannon opened this issue Jan 1, 2024 · 3 comments
Closed

Update autoconf to warn when building under wasm32-unknown-emscripten #113632

brettcannon opened this issue Jan 1, 2024 · 3 comments
Assignees
@brettcannon
Labels
3.13 new features, bugs and security fixes build The build process and cross-build deferred-blocker OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Jan 1, 2024 •
edited by bedevere-app bot

Bug report

Bug description:

Support for wasm32-unknown-emscripten was dropped in python/peps#3612 . As part of PEP 11, a configure error needs to be triggered when building for the platform.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error build The build process and cross-build OS-wasi 3.13 new features, bugs and security fixes deferred-blocker labels Jan 1, 2024
@brettcannon brettcannon mentioned this issue Jan 4, 2024
Closed
@brettcannon
Copy link
Member Author

This is blocked on the SC answering python/steering-council#226 .

@brettcannon
Copy link
Member Author

Another option is to have a warning anytime you build on a platform that isn't supported.

@erlend-aasland
Copy link
Contributor

Another option is to have a warning anytime you build on a platform that isn't supported.

We already have the following code in place:

https://github.com/python/cpython/blob/5ce193e65a7e6f239337a8c5305895cf8a4d2726/configure.ac#L961C13-L995

Removing this line...:

cpython/configure.ac

Line 982 in 5ce193e

[wasm32-unknown-emscripten/clang], [PY_SUPPORT_TIER=3], dnl WebAssembly Emscripten

... should end up producing a warning.

@brettcannon brettcannon changed the title Add error to autoconf when building under wasm32-unknown-emscripten Update autoconf to warn when building under wasm32-unknown-emscripten Feb 1, 2024
@brettcannon brettcannon self-assigned this Feb 1, 2024
brettcannon added a commit to brettcannon/cpython that referenced this issue Feb 9, 2024
@brettcannon
pythonGH-113632: update configure.ac for WebAssembly support tiers
366dbb8 
Move WASI to tier 2 and drop Emscripten.
@bedevere-app bedevere-app bot mentioned this issue Feb 9, 2024
Merged
erlend-aasland pushed a commit that referenced this issue Feb 9, 2024
@brettcannon
GH-113632: update configure.ac for WebAssembly support tiers (#115192)
c968dc7 
Move WASI to tier 2 and drop Emscripten.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@brettcannon @fsc-eriker
pythonGH-113632: update configure.ac for WebAssembly support tiers (p…
178acc2 
…ython#115192)

Move WASI to tier 2 and drop Emscripten.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Apr 13, 2024
@erlend-aasland
pythongh-96398: Purge Emscripten code from configure.ac
ad44734 
See pythongh-113632 and python/peps#3612: Emscripten is no longer supported
@erlend-aasland erlend-aasland mentioned this issue Apr 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettcannon brettcannon

Labels
3.13 new features, bugs and security fixes build The build process and cross-build deferred-blocker OS-wasi type-bug An unexpected behavior, bug, or error
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @erlend-aasland