Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose unprefixed variants of _PyCFunctionFast and _PyCFunctionFastWithKeywords #114626

Closed
davidhewitt opened this issue Jan 26, 2024 · 1 comment · Fixed by #114627
Closed

Expose unprefixed variants of _PyCFunctionFast and _PyCFunctionFastWithKeywords #114626

davidhewitt opened this issue Jan 26, 2024 · 1 comment · Fixed by #114627
Labels
topic-C-API type-feature A feature request or enhancement

Comments

@davidhewitt
Copy link
Contributor

davidhewitt commented Jan 26, 2024 •
edited by bedevere-app bot

METH_FASTCALL is documented as part of the stable API since Python 3.10.

The accompanying function pointer typedefs _PyCFunctionFast and _PyCFunctionFastWithKeywords have leading underscore names, which I understand to hint at these being private / internal APIs.

I think this is potentially an oversight and these function pointer typedefs should have new public names PyCFunctionFast and PyCFunctionFastWithKeywords?

Linked PRs
@davidhewitt davidhewitt mentioned this issue Jan 26, 2024
Merged
@erlend-aasland erlend-aasland added the type-feature A feature request or enhancement label Feb 1, 2024
encukou added a commit that referenced this issue Feb 15, 2024
@davidhewitt @encukou
gh-114626: add PyCFunctionFast and PyCFunctionFastWithKeywords (GH-11…
9e3729b 
…4627)


Co-authored-by: Petr Viktorin <encukou@gmail.com>
vstinner added a commit to vstinner/cpython that referenced this issue Feb 16, 2024
@vstinner
pythongh-114626: Fix _PyCFunctionFastWithKeywords backward compat alias
ac463c8 
Keep the old private _PyCFunctionFastWithKeywords name as an alias to
the new public name PyCFunctionFastWithKeywords.

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
vstinner added a commit to vstinner/cpython that referenced this issue Feb 16, 2024
@vstinner
pythongh-114626: Add again _PyCFunctionFastWithKeywords name
97b5190 
Keep the old private _PyCFunctionFastWithKeywords name as an alias to
the new public name PyCFunctionFastWithKeywords.

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
vstinner added a commit to vstinner/cpython that referenced this issue Feb 16, 2024
@vstinner
pythongh-114626: Add again _PyCFunctionFastWithKeywords name
b77ecfe 
Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)
as an alias to the new public name PyCFunctionFastWithKeywords
(Python 3.13a4).

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
@bedevere-app bedevere-app bot mentioned this issue Feb 16, 2024
Merged
encukou pushed a commit that referenced this issue Feb 19, 2024
@vstinner
gh-114626: Add again _PyCFunctionFastWithKeywords name (GH-115561)
aa8c1a0 
Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)
as an alias to the new public name PyCFunctionFastWithKeywords
(Python 3.13a4).

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
@vstinner
Copy link
Member

Thanks for making these two names public @davidhewitt!

befeleme pushed a commit to fedora-python/cpython that referenced this issue Feb 22, 2024
@vstinner @befeleme
00420: pythongh-114626: Add again _PyCFunctionFastWithKeywords name (p…
d9d7e46 
…ythonGH-115561)

Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)
as an alias to the new public name PyCFunctionFastWithKeywords
(Python 3.13a4).

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
This was referenced Feb 25, 2024
Open
Merged
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@vstinner @woodruffw
pythongh-114626: Add again _PyCFunctionFastWithKeywords name (pythonG…
44e7dd4 
…H-115561)

Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)
as an alias to the new public name PyCFunctionFastWithKeywords
(Python 3.13a4).

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@vstinner @diegorusso
pythongh-114626: Add again _PyCFunctionFastWithKeywords name (pythonG…
d70099d 
…H-115561)

Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)
as an alias to the new public name PyCFunctionFastWithKeywords
(Python 3.13a4).

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas
_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-C-API type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-114626: add PyCFunctionFast and PyCFunctionFastWithKeywords davidhewitt/cpython
4 participants
@vstinner @davidhewitt @erlend-aasland @Eclips4