Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_os permanently change the process priority #115596

Closed
serhiy-storchaka opened this issue Feb 17, 2024 · 0 comments · Fixed by #115610
Closed

test_os permanently change the process priority #115596

serhiy-storchaka opened this issue Feb 17, 2024 · 0 comments · Fixed by #115610
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Feb 17, 2024 •
edited by bedevere-app bot

Bug report

ProgramPriorityTests in test_os changes the process priority (makes it less prioritized in the scheduler) and then tries to restore the old value, why is fail unless the test is ran as root. It affects all further tests if run in sequential mode and all further tests in test_os if run in parallel mode. It can makes the testing process less responsible and make some tests (especially relying on timeouts or interruption) unstable.

This test should be run in a separate subprocess.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir 3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes labels Feb 17, 2024
@brianschubert brianschubert mentioned this issue Feb 17, 2024
Merged
serhiy-storchaka pushed a commit that referenced this issue Feb 17, 2024
@brianschubert
gh-115596: Fix ProgramPriorityTests in test_os permanently changing t…
90dd653 
…he process priority (GH-115610)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 17, 2024
@brianschubert @miss-islington
pythongh-115596: Fix ProgramPriorityTests in test_os permanently chan…
d9f63b2 
…ging the process priority (pythonGH-115610)

(cherry picked from commit 90dd653)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 17, 2024
@brianschubert @miss-islington
pythongh-115596: Fix ProgramPriorityTests in test_os permanently chan…
89585f7 
…ging the process priority (pythonGH-115610)

(cherry picked from commit 90dd653)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
This was referenced Feb 17, 2024
Merged
Merged
serhiy-storchaka pushed a commit that referenced this issue Feb 17, 2024
@miss-islington @brianschubert
[3.12] gh-115596: Fix ProgramPriorityTests in test_os permanently cha…
dadc768 
…nging the process priority (GH-115610) (GH-115616)

(cherry picked from commit 90dd653)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
serhiy-storchaka pushed a commit that referenced this issue Feb 17, 2024
@miss-islington @brianschubert
[3.11] gh-115596: Fix ProgramPriorityTests in test_os permanently cha…
cd0a071 
…nging the process priority (GH-115610) (GH-115617)

(cherry picked from commit 90dd653)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@brianschubert @woodruffw
pythongh-115596: Fix ProgramPriorityTests in test_os permanently chan…
8ca8d8b 
…ging the process priority (pythonGH-115610)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@brianschubert @diegorusso
pythongh-115596: Fix ProgramPriorityTests in test_os permanently chan…
2504b68 
…ging the process priority (pythonGH-115610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
1 participant
@serhiy-storchaka