Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytecodes cleanup: promote TIER_{ONE,TWO}_ONLY to properties #115778

Closed
gvanrossum opened this issue Feb 21, 2024 · 4 comments
Closed

Bytecodes cleanup: promote TIER_{ONE,TWO}_ONLY to properties #115778

gvanrossum opened this issue Feb 21, 2024 · 4 comments
Assignees
Labels
easy interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Feb 21, 2024

Instead of

op(FOO, (left, right -- res)) {
    TIER_TWO_ONLY
    <actual code>
}

I'd like to be able to write

tier2 op(FOO, (left, right -- res)) {
    <actual code>
}

Linked PRs

@gvanrossum gvanrossum added interpreter-core (Objects, Python, Grammar, and Parser dirs) easy labels Feb 21, 2024
@gvanrossum
Copy link
Member Author

If someone wants to pick this up I'm happy to provide some clues as to where to make changes (but multi-file grep goes a long way. :-)

@Eclips4
Copy link
Member

Eclips4 commented Feb 21, 2024

I would like to pick this up if you don't mind :)

@gvanrossum
Copy link
Member Author

@Eclips4 Go for it! Remember to run make regen-cases frequently (after each change to the generator and each change to bytecodes.c or the redundancy eliminator input file).

@gvanrossum
Copy link
Member Author

For the CI failures, see gh-115859. Once that's fixed, please merge the latest main and push again.

gvanrossum pushed a commit that referenced this issue Feb 23, 2024
This replaces the old `TIER_{ONE,TWO}_ONLY` macros. Note that `specialized` implies `tier1`.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@Eclips4 Eclips4 closed this as completed Feb 23, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
…ython#115815)

This replaces the old `TIER_{ONE,TWO}_ONLY` macros. Note that `specialized` implies `tier1`.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
…ython#115815)

This replaces the old `TIER_{ONE,TWO}_ONLY` macros. Note that `specialized` implies `tier1`.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

No branches or pull requests

2 participants