Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 705 (TypedDict: Read-only items) #116127

Closed
3 tasks
JelleZijlstra opened this issue Feb 29, 2024 · 5 comments
Closed
3 tasks

Implement PEP 705 (TypedDict: Read-only items) #116127

JelleZijlstra opened this issue Feb 29, 2024 · 5 comments
Assignees
@sobolevn
Labels
3.13 new features, bugs and security fixes topic-typing type-feature A feature request or enhancement

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Feb 29, 2024 •
edited by bedevere-app bot

Feature or enhancement

PEP-705 was just accepted. For the runtime implementation, we'll need:

  • Add the new ReadOnly special form
  • Adjust the implementation of TypedDict
  • Update docs

The typing-extensions implementation should provide a good baseline.

cc @alicederyn

Linked PRs
@JelleZijlstra JelleZijlstra added type-feature A feature request or enhancement topic-typing 3.13 new features, bugs and security fixes labels Feb 29, 2024
@sobolevn
Copy link
Member

sobolevn commented Mar 1, 2024

Is someone working on this already? :)
Or can I take this over?

@JelleZijlstra
Copy link
Member Author

I am not working on it, feel free to take it. Thanks!

@sobolevn sobolevn self-assigned this Mar 1, 2024
@sobolevn
Copy link
Member

sobolevn commented Mar 1, 2024

Basically, the implementation exists here: python/typing_extensions@0b0166d

I just need to port it.

@sobolevn sobolevn mentioned this issue Mar 5, 2024
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 5, 2024
@sobolevn
pythongh-116127: PEP-705: Add ReadOnly support for TypedDict
bb29d9b
@bedevere-app bedevere-app bot mentioned this issue Mar 5, 2024
Merged
JelleZijlstra added a commit that referenced this issue Mar 12, 2024
@sobolevn @JelleZijlstra
gh-116127: PEP-705: Add ReadOnly support for TypedDict (#116350)
df4784b 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@sobolevn @JelleZijlstra @adorilson
pythongh-116127: PEP-705: Add ReadOnly support for TypedDict (pyt…
a3efa11 
…hon#116350)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra
Copy link
Member Author

@sobolevn any progress here? The beta freeze is approaching.

@JelleZijlstra
Copy link
Member Author

Wait, it was done. Thank you!

diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @JelleZijlstra @diegorusso
pythongh-116127: PEP-705: Add ReadOnly support for TypedDict (pyt…
3505334 
…hon#116350)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.13 new features, bugs and security fixes topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @sobolevn