Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the instruction sequence data structure into its own file and add a Python interface #117494

Open
iritkatriel opened this issue Apr 3, 2024 · 2 comments
Open

Extract the instruction sequence data structure into its own file and add a Python interface #117494

iritkatriel opened this issue Apr 3, 2024 · 2 comments
Assignees
@iritkatriel
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Apr 3, 2024 •
edited by bedevere-app bot

The Instruction Sequence data structure used by the compiler/assembler should be extracted into its own file, so that it can be properly abstracted. It should get a convenient Python interface so that it can be directly accessed from tests without translation to and from a list-of-tuples representation.

Linked PRs
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Apr 3, 2024
@iritkatriel iritkatriel self-assigned this Apr 3, 2024
@bedevere-app bedevere-app bot mentioned this issue Apr 3, 2024
Merged
iritkatriel added a commit that referenced this issue Apr 4, 2024
@iritkatriel
gh-117494: extract the Instruction Sequence data structure into a sep…
04697bc 
…arate file (#117496)
@encukou
Copy link
Member

encukou commented Apr 5, 2024

Since the PR was merged, the wasm32-wasi Non-Debug 3.x buildbot has been consistently failing in test_dynamic.
I can't reproduce the failure locally using .devcontainer.

@ericsnowcurrently, can you reproduce?

@iritkatriel
Copy link
Member Author

Is there something I needed to change in the makefiles for WASI when I added a new source file?

diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@iritkatriel @diegorusso
pythongh-117494: extract the Instruction Sequence data structure into…
01de6b0 
… a separate file (python#117496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@encukou @iritkatriel