Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation for sqlite3.Binary #118469

Open
jonathan-geoseer opened this issue May 1, 2024 · 4 comments
Open

No documentation for sqlite3.Binary #118469

jonathan-geoseer opened this issue May 1, 2024 · 4 comments
Labels
docs Documentation in the Doc dir easy topic-sqlite3

Comments

@jonathan-geoseer
Copy link

jonathan-geoseer commented May 1, 2024

https://docs.python.org/3/library/sqlite3.html - does not have any documentation for sqlite3.Binary() method

Linked PRs

@jonathan-geoseer jonathan-geoseer added the docs Documentation in the Doc dir label May 1, 2024
@erlend-aasland
Copy link
Contributor

Binary() is a part of PEP-249; see https://peps.python.org/pep-0249/#binary

Note that the other PEP-249 constructors are not documented either:

  • Date()
  • Time()
  • Timestamp()
  • DateFromTicks()
  • TimeFromTicks()
  • TimestampFromTicks()

@firat-v
Copy link

firat-v commented May 3, 2024

Hello,

A bit of background: I've been learning programming for a few years now. I developed and keep developing projects of my own using mainly shell, C and Python (hosted in gitlab). I want to become an active contributor in the FOSS ecosystem, and I believe Python would be a good place to start. So I searched issues with an 'easy' tag and found this one. I'm familiar with reST and SQL at a beginner level, and I'm learning sqlite3 for my own projects. I set up my development environment as directed in the devguide, built python and its documentation, and ran all the tests.

Now back to the issue at hand: I looked at PEP-249, the documentation for sqlite and its module, and found Lib/sqlite3/dbapi2.py. However, I don't know where to go from here. I'm eager to learn and would be glad if given directions.

Thank you for your time.

@erlend-aasland
Copy link
Contributor

I'm eager to learn and would be glad if given directions.

Great; first, take a look at the devguide section for documentation:

I also encourage taking a look at our documentation north star, Diátaxis: https://diataxis.fr

The missing documentation should be added to the file Doc/library/sqlite3.rst in the CPython repo. IMO, the missing constructors should be documented under the Module functions header (between line 259 and line 425 in Doc/library/sqlite3.rst). I suggest to add them at the end of that section.

Shout out if you need more info :)

@firat-v
Copy link

firat-v commented May 11, 2024

Thank you :) Now I have a clear map in my head and explored most of it. Started implementing. I'll have a pull request by Monday.

firat-v added a commit to firat-v/cpython that referenced this issue May 12, 2024
firat-v added a commit to firat-v/cpython that referenced this issue May 12, 2024
firat-v added a commit to firat-v/cpython that referenced this issue May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir easy topic-sqlite3
Projects
None yet
Development

No branches or pull requests

4 participants