Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer import warnings in pathlib #119049

Closed
barneygale opened this issue May 14, 2024 · 2 comments
Closed

Defer import warnings in pathlib #119049

barneygale opened this issue May 14, 2024 · 2 comments
Labels
performance Performance or resource usage topic-pathlib

Comments

@barneygale
Copy link
Contributor

barneygale commented May 14, 2024 •
edited by bedevere-app bot

As of GH-118793, the warnings module is used only once in pathlib, by PurePath.is_reserved(). We should be able to move the import warnings line into that method. But beware! Doing so seems to cause a failure in test_io, which needs further investigation.

Linked PRs
@barneygale barneygale added performance Performance or resource usage topic-pathlib labels May 14, 2024
@barneygale barneygale mentioned this issue May 14, 2024
Merged
Eclips4 added a commit to Eclips4/cpython that referenced this issue May 15, 2024
@Eclips4
pythongh-119049: Fix incorrect display of warning which is constructe…
88b9e20 
…d by C API
@Eclips4 Eclips4 mentioned this issue May 15, 2024
Merged
@Eclips4
Copy link
Member

Eclips4 commented May 15, 2024

But beware! Doing so seems to cause a failure in test_io, which needs further investigation.

I've written #119063 to address this. FYI, this is not related to pathlib :)

serhiy-storchaka pushed a commit that referenced this issue May 16, 2024
@Eclips4
gh-119049: Fix incorrect display of warning which is constructed by C…
100c7ab 
… API (GH-119063)

The source line was not displayed if the warnings module had not yet
been imported.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 16, 2024
@Eclips4 @miss-islington
pythongh-119049: Fix incorrect display of warning which is constructe…
0de65e5 
…d by C API (pythonGH-119063)

The source line was not displayed if the warnings module had not yet
been imported.
(cherry picked from commit 100c7ab)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app bedevere-app bot mentioned this issue May 16, 2024
Merged
Eclips4 added a commit to Eclips4/cpython that referenced this issue May 17, 2024
@Eclips4
pythongh-119049: Defer import warnings
4a0be46
This was referenced May 17, 2024
Merged
Closed
serhiy-storchaka pushed a commit that referenced this issue May 17, 2024
@miss-islington @Eclips4
[3.13] gh-119049: Fix incorrect display of warning which is construct…
ced71d3 
…ed by C API (GH-119063) (GH-119106)

The source line was not displayed if the warnings module had not yet
been imported.
(cherry picked from commit 100c7ab)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
barneygale pushed a commit that referenced this issue May 17, 2024
@Eclips4
gh-119049: Defer import warnings in pathlib._local (#119111)
31a28cb
@barneygale
Copy link
Contributor Author

Woot! Thank you @Eclips4 for sorting this :)

@JelleZijlstra JelleZijlstra mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage topic-pathlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barneygale @Eclips4