Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tier Two Optimizer Eliminate Function Version Guards #119476

Open
saulshanabrook opened this issue May 23, 2024 · 0 comments
Open

Tier Two Optimizer Eliminate Function Version Guards #119476

saulshanabrook opened this issue May 23, 2024 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@saulshanabrook
Copy link
Contributor

saulshanabrook commented May 23, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Suggested by @brandtbucher at the PyCon sprints

The tier two interpreter currently adds additional function function guards when it doesn't need to. We can use the function watcher to track when the function version changes and only add the first one.

Similar to the issue for type version guards #119258 and the implemented solution #119365

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@saulshanabrook saulshanabrook added the type-feature A feature request or enhancement label May 23, 2024
This was referenced May 24, 2024
Open
Merged
brandtbucher added a commit that referenced this issue May 28, 2024
@brandtbucher
GH-119476: Split _CHECK_FUNCTION_VERSION out of _CHECK_FUNCTION_EXACT…
cfcc054 
…_ARGS (GH-119510)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@brandtbucher @noahbkim
pythonGH-119476: Split _CHECK_FUNCTION_VERSION out of _CHECK_FUNCTION…
bd84fe4 
…_EXACT_ARGS (pythonGH-119510)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@brandtbucher @estyxx
pythonGH-119476: Split _CHECK_FUNCTION_VERSION out of _CHECK_FUNCTION…
844a0f0 
…_EXACT_ARGS (pythonGH-119510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saulshanabrook