-
-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests badge in README shows incorrect status #119961
Comments
hugovk
pushed a commit
that referenced
this issue
Jun 3, 2024
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the repo README, the tests badge currently shows as failing even though all the recent tests workflows on main are passing.
![image](https://private-user-images.githubusercontent.com/22353562/335917812-0250768c-08e7-4c21-ae75-c8ff9c97a382.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExOTE0NjUsIm5iZiI6MTcyMTE5MTE2NSwicGF0aCI6Ii8yMjM1MzU2Mi8zMzU5MTc4MTItMDI1MDc2OGMtMDhlNy00YzIxLWFlNzUtYzhmZjljOTdhMzgyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE3VDA0MzkyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNhMTZmN2Y4ODVjNzFjMTRiMTQ2ZTYwOGY3ODFkYjRlMzhkNWU5ZmY2NDdlNjM4MzcxNzE3ZGY0ZWFiMjM4NjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.mOnFHI0efSBzpImen7eaujsxpqHQoNosmN9wwyrgcrw)
The URL currently being used is https://github.com/python/cpython/workflows/Tests/badge.svg, which is an old, now undocumented way to select a badge. I can't actually work out where that's finding a failing workflow but apparently it's a bit dodgy so moving to the new format based on the file name, https://github.com/python/cpython/actions/workflows/build.yml/badge.svg, seems like a good idea, and seems to fix the issue.
PR Incoming
Linked PRs
The text was updated successfully, but these errors were encountered: