Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests badge in README shows incorrect status #119961

Closed
wookie184 opened this issue Jun 3, 2024 · 0 comments · Fixed by #119962
Closed

Tests badge in README shows incorrect status #119961

wookie184 opened this issue Jun 3, 2024 · 0 comments · Fixed by #119962

Comments

@wookie184
Copy link
Contributor

wookie184 commented Jun 3, 2024

In the repo README, the tests badge currently shows as failing even though all the recent tests workflows on main are passing.
image

The URL currently being used is https://github.com/python/cpython/workflows/Tests/badge.svg, which is an old, now undocumented way to select a badge. I can't actually work out where that's finding a failing workflow but apparently it's a bit dodgy so moving to the new format based on the file name, https://github.com/python/cpython/actions/workflows/build.yml/badge.svg, seems like a good idea, and seems to fix the issue.

PR Incoming

Linked PRs

hugovk pushed a commit that referenced this issue Jun 3, 2024
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
mliezun pushed a commit to mliezun/cpython that referenced this issue Jun 3, 2024
)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant